From patchwork Tue Jul 12 21:27:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Pitre X-Patchwork-Id: 9226279 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 56B46608A1 for ; Tue, 12 Jul 2016 21:47:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4CF7C27F9C for ; Tue, 12 Jul 2016 21:47:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 421F327FA1; Tue, 12 Jul 2016 21:47:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E45A327F9C for ; Tue, 12 Jul 2016 21:47:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751227AbcGLVpy (ORCPT ); Tue, 12 Jul 2016 17:45:54 -0400 Received: from alt42.smtp-out.videotron.ca ([23.233.128.29]:28517 "EHLO alt42.smtp-out.videotron.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751730AbcGLVnX (ORCPT ); Tue, 12 Jul 2016 17:43:23 -0400 X-Greylist: delayed 905 seconds by postgrey-1.27 at vger.kernel.org; Tue, 12 Jul 2016 17:43:23 EDT Received: from yoda.home ([96.23.157.65]) by Videotron with SMTP id N5DlbZ9PVcMN9N5DmbL7qR; Tue, 12 Jul 2016 17:28:02 -0400 X-Authority-Analysis: v=2.1 cv=YqOvP9sX c=1 sm=1 tr=0 a=keA3yYpnlypCNW5BNWqu+w==:117 a=keA3yYpnlypCNW5BNWqu+w==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=cAmyUtKerLwA:10 a=KKAkSRfTAAAA:8 a=R5CuANmm5DveqMR5uOoA:9 a=cvBusfyB2V15izCimMoJ:22 Received: from xanadu.home (xanadu.home [192.168.2.2]) by yoda.home (Postfix) with ESMTP id 776702DA0694; Tue, 12 Jul 2016 17:28:00 -0400 (EDT) From: Nicolas Pitre To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Alexander Viro , David Howells , Greg Ungerer Subject: [PATCH 08/10] binfmt_flat: update libraries' data segment pointer with userspace accessors Date: Tue, 12 Jul 2016 17:27:40 -0400 Message-Id: <1468358862-11799-9-git-send-email-nicolas.pitre@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1468358862-11799-1-git-send-email-nicolas.pitre@linaro.org> References: <1468358862-11799-1-git-send-email-nicolas.pitre@linaro.org> X-CMAE-Envelope: MS4wfEmKZee41JYMdOgpiOBoaH+yTOHnXmRPJQlqEfdNbXwuDDvHJ+X0GwdvMBhz4Tj2hb0KGiYIxuCFNZ8BozAd1tnuujbU23LWwSPnm4q/eaxo3B7cle6C VWSP76iqMlEmvetqtDad7KXyAuG74mWs9m90bx9B1Lanp9KxILbWHr44mHdUpi8HQ0p8YSQsfBNZFwNbhVNDEz5Yrs5+vYFfF++GdymJCUevYKM6RXh09IEO FvE93mx1UEAsF1ixviN38Ti9qkO8hDIzT4eOXcI/Isa2v/bleJxXMMPIoclgPPqySSnAay0sZfjFq7e50e+YMw== Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is needed on systems with a MMU. This also gets rid of the strangest C code I've seen lateli i.e. an integer indexed with a pointer value within square brackets. That really looked backwards. Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index e981e66bb5..3221ed9d7c 100644 --- a/fs/binfmt_flat.c +++ b/fs/binfmt_flat.c @@ -902,12 +902,19 @@ static int load_flat_binary(struct linux_binprm * bprm) return res; /* Update data segment pointers for all libraries */ - for (i=0; i