From patchwork Mon Jul 18 03:31:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Pitre X-Patchwork-Id: 9234025 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 110FC6075D for ; Mon, 18 Jul 2016 03:48:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 04156212F2 for ; Mon, 18 Jul 2016 03:48:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EC9DA26A99; Mon, 18 Jul 2016 03:48:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 83907212F2 for ; Mon, 18 Jul 2016 03:48:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751630AbcGRDr3 (ORCPT ); Sun, 17 Jul 2016 23:47:29 -0400 Received: from alt32.smtp-out.videotron.ca ([24.53.0.21]:2546 "EHLO alt32.smtp-out.videotron.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbcGRDrM (ORCPT ); Sun, 17 Jul 2016 23:47:12 -0400 Received: from yoda.home ([96.23.157.65]) by Videotron with SMTP id OzHubEvtSWjC4OzHvbwoN9; Sun, 17 Jul 2016 23:32:11 -0400 X-Authority-Analysis: v=2.1 cv=FfyXvMK6 c=1 sm=1 tr=0 a=keA3yYpnlypCNW5BNWqu+w==:117 a=keA3yYpnlypCNW5BNWqu+w==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=cAmyUtKerLwA:10 a=KKAkSRfTAAAA:8 a=R5CuANmm5DveqMR5uOoA:9 a=cvBusfyB2V15izCimMoJ:22 Received: from xanadu.home (xanadu.home [192.168.2.2]) by yoda.home (Postfix) with ESMTP id C91B32DA0694; Sun, 17 Jul 2016 23:32:08 -0400 (EDT) From: Nicolas Pitre To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Alexander Viro , David Howells , Greg Ungerer Subject: [PATCH v2 08/10] binfmt_flat: update libraries' data segment pointer with userspace accessors Date: Sun, 17 Jul 2016 23:31:54 -0400 Message-Id: <1468812716-30537-9-git-send-email-nicolas.pitre@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1468812716-30537-1-git-send-email-nicolas.pitre@linaro.org> References: <1468812716-30537-1-git-send-email-nicolas.pitre@linaro.org> X-CMAE-Envelope: MS4wfIb2XnzM/DaUqGyVb+CSBaskUm3/OHFraQA/MHpceYAgKr5DrupcDUjVF+OQqiSFPj9L8ltPpYLAdmU75zMB02sHNSwDNJzN+/XlckW3RD0LeeNBs9D7 w71QKN3Qn54soYIi5YJVQ48PZ603hdkW87LA8fPEtDtKSX9tEnVo8X/hwOqx2/6ZDZ8Emdd6VQJjIEx1fx8KvfwwK9DF0zcgE5ZboNlZAToaaDE9PL03hk3z tIS/16WkjJVVLcAaijxoTBL+SY0sBegHlO8CYKGLg8zXdZjL4x0Mt8f/JWPzmWdDwt+6fBBCEUrj24sCs+1VHQ== Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is needed on systems with a MMU. This also gets rid of the strangest C code I've seen lateli i.e. an integer indexed with a pointer value within square brackets. That really looked backwards. Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index e981e66bb5..3221ed9d7c 100644 --- a/fs/binfmt_flat.c +++ b/fs/binfmt_flat.c @@ -902,12 +902,19 @@ static int load_flat_binary(struct linux_binprm * bprm) return res; /* Update data segment pointers for all libraries */ - for (i=0; i