From patchwork Fri Jun 16 17:24:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 9792293 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AC02C60231 for ; Fri, 16 Jun 2017 17:24:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9070128405 for ; Fri, 16 Jun 2017 17:24:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 854DD2866E; Fri, 16 Jun 2017 17:24:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0ABF228456 for ; Fri, 16 Jun 2017 17:24:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752143AbdFPRYv (ORCPT ); Fri, 16 Jun 2017 13:24:51 -0400 Received: from mail-it0-f41.google.com ([209.85.214.41]:38150 "EHLO mail-it0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752120AbdFPRYt (ORCPT ); Fri, 16 Jun 2017 13:24:49 -0400 Received: by mail-it0-f41.google.com with SMTP id b205so16766646itg.1 for ; Fri, 16 Jun 2017 10:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6gOBbCMpwmeWs3MVjjmH2O89tnnJxTOmO1dIAAzRCVI=; b=fdoYZfmIAgBYYpsFZOmbcolDISm2e8ojxye6IO1onpKRPIsCUsUVwgaAydj6NOvU6N 7VusEqWO2GIkAgXDTU+o2S8a0qIgh7TLS7158xPunFgfQ2jAcQYvnh1jrSE21CwejZjt CkYwEkHIxGPmrCuAHKReQZINTJRCtpdlMSAQSrz3uXZ6FUrJuZRTsHuAaX98KyA33kXE Ca7DT1WkpjpydBEyivZyEAxEa7hfiYbVkWHJwKYJqEgW9F2LP82xOpn4A4rv5VI8HcE9 Gn88f5SzcfclDh+jJOhah3qUq+1T4j83VOBOWNmjt2rjgzU1EB66qeYKvy2KzabsNpDN 1ipg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6gOBbCMpwmeWs3MVjjmH2O89tnnJxTOmO1dIAAzRCVI=; b=ILdYYQNY7VqQLpCSqWMkS/hpH/rpeCedD4f/vxXwiCdTB08+OcfrKFio5VqnsoZdfh 2Zfx176wfn77yk3Zs+7tg/WZFZ0biLQ5o8Ks8F9zfKozVYZ7ivdWH7SB/Xj8CqCObDWx eWN79fGp0zPf2z0W72dt/+Q9ywtUjKsXPcrHCmzlywo7spoM/Ro3VsZy5mkFUXylrNr0 GNVyP1pPuIBD+WkOhkyf24R1uqs9Z+tX8oiviEQVD4ZhpYIPB/BZQifFzurLJdDD+Soz 1d88ftXg26I4asg87cvAUWRYOwn1lVjCP4Oy+SvtvxZ+l8N6c2VXZReemp8M4NmT+TGi 9pgg== X-Gm-Message-State: AKS2vOyWdKUqpdNRfd/96mE9cpwY3m5HyTjuxKEkww/UorPy5w5rjPPP m9qtOBKnqloHcghdgEI5vg== X-Received: by 10.36.137.6 with SMTP id s6mr63219itd.96.1497633887869; Fri, 16 Jun 2017 10:24:47 -0700 (PDT) Received: from localhost.localdomain ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id e31sm1661101ioi.51.2017.06.16.10.24.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 16 Jun 2017 10:24:47 -0700 (PDT) From: Jens Axboe To: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org Cc: adilger@dilger.ca, hch@infradead.org, martin.petersen@oracle.com, Jens Axboe Subject: [PATCH 01/11] fs: add support for an inode to carry write hint related data Date: Fri, 16 Jun 2017 11:24:33 -0600 Message-Id: <1497633883-21230-2-git-send-email-axboe@kernel.dk> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1497633883-21230-1-git-send-email-axboe@kernel.dk> References: <1497633883-21230-1-git-send-email-axboe@kernel.dk> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP No functional changes in this patch, just in preparation for allowing applications to pass in hints about data life times for writes. Set aside 3 bits for carrying hint information in the inode flags. Adds the public hints as well, which are: WRITE_LIFE_NONE No hints about write life time WRITE_LIFE_SHORT Data written has a short life time WRITE_LIFE_MEDIUM Data written has a medium life time WRITE_LIFE_LONG Data written has a long life time WRITE_LIFE_EXTREME Data written has an extremely long life tim Helpers are defined to store these values in flags, by passing in the shift that's appropriate for the given use case. Signed-off-by: Jens Axboe --- fs/inode.c | 11 +++++++++++ include/linux/fs.h | 29 +++++++++++++++++++++++++++++ include/uapi/linux/fs.h | 13 +++++++++++++ 3 files changed, 53 insertions(+) diff --git a/fs/inode.c b/fs/inode.c index db5914783a71..defb015a2c6d 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -2120,3 +2120,14 @@ struct timespec current_time(struct inode *inode) return timespec_trunc(now, inode->i_sb->s_time_gran); } EXPORT_SYMBOL(current_time); + +void inode_set_write_hint(struct inode *inode, enum rw_hint hint) +{ + unsigned int flags = write_hint_to_mask(hint, S_WRITE_LIFE_SHIFT); + + if (flags != mask_to_write_hint(inode->i_flags, S_WRITE_LIFE_SHIFT)) { + inode_lock(inode); + inode_set_flags(inode, flags, S_WRITE_LIFE_MASK); + inode_unlock(inode); + } +} diff --git a/include/linux/fs.h b/include/linux/fs.h index 803e5a9b2654..472c83156606 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1828,6 +1828,14 @@ struct super_operations { #endif /* + * Expected life time hint of a write for this inode. This uses the + * WRITE_LIFE_* encoding, we just need to define the shift. We need + * 3 bits for this. Next S_* value is 131072, bit 17. + */ +#define S_WRITE_LIFE_MASK 0x1c000 /* bits 14..16 */ +#define S_WRITE_LIFE_SHIFT 14 /* 16384, next bit */ + +/* * Note that nosuid etc flags are inode-specific: setting some file-system * flags just means all the inodes inherit those flags by default. It might be * possible to override it selectively if you really wanted to with some @@ -1873,6 +1881,26 @@ static inline bool HAS_UNMAPPED_ID(struct inode *inode) return !uid_valid(inode->i_uid) || !gid_valid(inode->i_gid); } +static inline unsigned int write_hint_to_mask(enum rw_hint hint, + unsigned int shift) +{ + return hint << shift; +} + +static inline enum rw_hint mask_to_write_hint(unsigned int mask, + unsigned int shift) +{ + return (mask >> shift) & 0x7; +} + +static inline unsigned int inode_write_hint(struct inode *inode) +{ + if (inode) + return mask_to_write_hint(inode->i_flags, S_WRITE_LIFE_SHIFT); + + return 0; +} + /* * Inode state bits. Protected by inode->i_lock * @@ -2757,6 +2785,7 @@ extern struct inode *new_inode(struct super_block *sb); extern void free_inode_nonrcu(struct inode *inode); extern int should_remove_suid(struct dentry *); extern int file_remove_privs(struct file *); +extern void inode_set_write_hint(struct inode *inode, enum rw_hint hint); extern void __insert_inode_hash(struct inode *, unsigned long hashval); static inline void insert_inode_hash(struct inode *inode) diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h index 24e61a54feaa..8fb3b5a6e1ec 100644 --- a/include/uapi/linux/fs.h +++ b/include/uapi/linux/fs.h @@ -356,6 +356,19 @@ struct fscrypt_key { #define SYNC_FILE_RANGE_WRITE 2 #define SYNC_FILE_RANGE_WAIT_AFTER 4 +/* + * Write life time hint values. + */ +enum rw_hint { + WRITE_LIFE_NONE = 0, + WRITE_LIFE_SHORT, + WRITE_LIFE_MEDIUM, + WRITE_LIFE_LONG, + WRITE_LIFE_EXTREME, +}; + +#define RW_HINT_MASK 0x7 /* 3 bits */ + /* flags for preadv2/pwritev2: */ #define RWF_HIPRI 0x00000001 /* high priority request, poll if possible */ #define RWF_DSYNC 0x00000002 /* per-IO O_DSYNC */