From patchwork Fri Jun 16 17:24:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 9792303 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5DD166038F for ; Fri, 16 Jun 2017 17:25:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 407492863F for ; Fri, 16 Jun 2017 17:25:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 355C62029B; Fri, 16 Jun 2017 17:25:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E176028210 for ; Fri, 16 Jun 2017 17:25:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353AbdFPRY6 (ORCPT ); Fri, 16 Jun 2017 13:24:58 -0400 Received: from mail-io0-f169.google.com ([209.85.223.169]:33559 "EHLO mail-io0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752139AbdFPRYv (ORCPT ); Fri, 16 Jun 2017 13:24:51 -0400 Received: by mail-io0-f169.google.com with SMTP id t87so34316335ioe.0 for ; Fri, 16 Jun 2017 10:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Lp3UMWmSJcLz6I4UTXd9WAvMVEMYX53/qtdZIbKXpMU=; b=v20Oj0QzMU8C1kHwX/+FukTKwGlp6gcmC9R+4NH9C7tfISeydcOjeEk7FC+Anb/t2C swHaC8hvB+oy8EFERNKklUFgLdMPrdtgP1wPojLBAGp57FuhQ4JVAGJ5AxuazJklqxUC PM//gyZ+Bwab56ANjv2nt+QKauEGyWdWT6TKJdDsMNebl1rxbJwDl1XANPq0yCF3Nsf9 sFAIbmBTEv4varDx13/7zPGDamzgydWLR2zEQFpS0NSjJK8jUVN3/h6RVaATsj1rMh2Y CSKiX5REXqwxwIJaRFd4gYjXimzvKEXEY/DdjrUgdW3BqTE7T2jvjvP1ns1S9pRT9jQ9 kAuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Lp3UMWmSJcLz6I4UTXd9WAvMVEMYX53/qtdZIbKXpMU=; b=k2vwXCSfswu2uS6+xv6katBZqV8GD80mFUg0oZr/X8VZZRzDWBz1r+VRqkAeu0fKED GI2QFFVQXk8S+YkNVyPCLFwfMB/1d9KsctUkagbwg5/QGbQkRHj41Kcy+P7TABLvxr9c jaf28y31TRNR/nhOzsuR9OCANWWqLco6+GSO3Q7QEPwh28cGvEMmlCjJUZGY6cdMkP/c jUnQ/Tozsmr6qwYshkhpFBA1qZi/QoTqlBUWA3sM4+L/XY2RUMwahD3o7k0bVacOpwr6 qy4kmGptK/H0f9YhM56UB3pCOJC+QxenyTpkON7HNfY+fUaQQut39ob1lNcQzLRENGu3 Sr2A== X-Gm-Message-State: AKS2vOzO5eCwo2TyGh+WY0IkGI7Sbq4D4DmlHXEeu9SxPXIYgPLLoTVk mFxaZV0Fkg/ssKo0ZPgFMw== X-Received: by 10.107.173.221 with SMTP id m90mr12912437ioo.152.1497633890232; Fri, 16 Jun 2017 10:24:50 -0700 (PDT) Received: from localhost.localdomain ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id e31sm1661101ioi.51.2017.06.16.10.24.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 16 Jun 2017 10:24:49 -0700 (PDT) From: Jens Axboe To: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org Cc: adilger@dilger.ca, hch@infradead.org, martin.petersen@oracle.com, Jens Axboe Subject: [PATCH 03/11] blk-mq: expose stream write hints through debugfs Date: Fri, 16 Jun 2017 11:24:35 -0600 Message-Id: <1497633883-21230-4-git-send-email-axboe@kernel.dk> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1497633883-21230-1-git-send-email-axboe@kernel.dk> References: <1497633883-21230-1-git-send-email-axboe@kernel.dk> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Useful to verify that things are working the way they should. Reading the file will return number of kb written with each write hint. Writing the file will reset the statistics. No care is taken to ensure that we don't race on updates. Drivers will write to q->write_hints[] if they handle a given write hint. Reviewed-by: Andreas Dilger Signed-off-by: Jens Axboe --- block/blk-mq-debugfs.c | 24 ++++++++++++++++++++++++ include/linux/blkdev.h | 3 +++ 2 files changed, 27 insertions(+) diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c index 803aed4d7221..b069a76f7fc7 100644 --- a/block/blk-mq-debugfs.c +++ b/block/blk-mq-debugfs.c @@ -133,6 +133,29 @@ static void print_stat(struct seq_file *m, struct blk_rq_stat *stat) } } +static int queue_write_hint_show(void *data, struct seq_file *m) +{ + struct request_queue *q = data; + int i; + + for (i = 0; i < BLK_MAX_WRITE_HINTS; i++) + seq_printf(m, "hint%d: %llu\n", i, q->write_hints[i]); + + return 0; +} + +static ssize_t queue_write_hint_store(void *data, const char __user *buf, + size_t count, loff_t *ppos) +{ + struct request_queue *q = data; + int i; + + for (i = 0; i < BLK_MAX_WRITE_HINTS; i++) + q->write_hints[i] = 0; + + return count; +} + static int queue_poll_stat_show(void *data, struct seq_file *m) { struct request_queue *q = data; @@ -656,6 +679,7 @@ const struct file_operations blk_mq_debugfs_fops = { static const struct blk_mq_debugfs_attr blk_mq_debugfs_queue_attrs[] = { {"poll_stat", 0400, queue_poll_stat_show}, {"state", 0600, queue_state_show, queue_state_write}, + {"write_hints", 0600, queue_write_hint_show, queue_write_hint_store}, {}, }; diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index b74a3edcb3da..ab36068f6129 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -588,6 +588,9 @@ struct request_queue { void *rq_alloc_data; struct work_struct release_work; + +#define BLK_MAX_WRITE_HINTS 5 + u64 write_hints[BLK_MAX_WRITE_HINTS]; }; #define QUEUE_FLAG_QUEUED 1 /* uses generic tag queueing */