From patchwork Fri Jun 16 17:24:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 9792319 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F32D56038F for ; Fri, 16 Jun 2017 17:25:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D7CE4200E7 for ; Fri, 16 Jun 2017 17:25:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CCB5B28210; Fri, 16 Jun 2017 17:25:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7DAA72029B for ; Fri, 16 Jun 2017 17:25:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752469AbdFPRZI (ORCPT ); Fri, 16 Jun 2017 13:25:08 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:35420 "EHLO mail-it0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752407AbdFPRZB (ORCPT ); Fri, 16 Jun 2017 13:25:01 -0400 Received: by mail-it0-f43.google.com with SMTP id m62so38651433itc.0 for ; Fri, 16 Jun 2017 10:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Vyi+AVwIdlAr4xetry/4fpIcIsK01ldeRXddKQknEIQ=; b=K8jLgWzLLtJ76I7rhZT3dKHFOiyAev+8+0mPnVD3u+kge3AipOaA65AUcr9yYM1yUc /8GV/ntfq0/AIVhq3iMkF8tz+nT403MaKH+JhrhwuFPHuH4MLnUbWoGvMRfUgQEhAK5n HiQvO0X9DmCmNSvULyMi3AR2+5QR2nw8cF0i7G6bFdCru9P8leMeN8BVFY5TsTjzQ1oB yAzWbqVrmdukrBsTrJFVuhQZSnDxJ2Ga0aXun1CifmTfyeQJQcYQbqrj+fK91HXxALIG hsVMrDnoZMj3M6RvFQtD3igsUa4x+kIlbG3vueYUcjev/F+nCOrSXHVy2bLk9BFnvO4x 807w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Vyi+AVwIdlAr4xetry/4fpIcIsK01ldeRXddKQknEIQ=; b=Tc1L3jROTEL1cYRwT9MMyf/taDjfkrKTdd8pcyk6rGyZwEPnfc4vN2Q0ayTv93UFf8 gM55o4gaGihXkG99DCctyBxmO2CTihn22SeWVaFp1WYP4St6MZAFVrl4VjaM5lWGDmo6 yBv2uoA2OLp+QGg7OlKDGBKZOP0IYdrQulhvV+OXvZAVGHioFsoZqV4vDKF9006ljMnj Rp9CsHVVCsv4bXt4D0b6M3PNjMp9dvODM9meaQHvGpm2gdMw9TRlNUsmI+pTptcAKBDY fTtf+vcXgkmR4f/SlENimEnF7HQB8RZnoEhnP62lwCjxkOO4ebn+tRbLhIA8eY9oEkcw EMlg== X-Gm-Message-State: AKS2vOztBz4qpvgG5GHwFQ9PulucYJazQhtmp8/MVET2wyWv5JQbhMbk 00pJuzAIDwadAkZvMr4XLA== X-Received: by 10.36.94.84 with SMTP id h81mr11796258itb.35.1497633895384; Fri, 16 Jun 2017 10:24:55 -0700 (PDT) Received: from localhost.localdomain ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id e31sm1661101ioi.51.2017.06.16.10.24.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 16 Jun 2017 10:24:54 -0700 (PDT) From: Jens Axboe To: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org Cc: adilger@dilger.ca, hch@infradead.org, martin.petersen@oracle.com, Jens Axboe Subject: [PATCH 07/11] fs: add support for buffered writeback to pass down write hints Date: Fri, 16 Jun 2017 11:24:39 -0600 Message-Id: <1497633883-21230-8-git-send-email-axboe@kernel.dk> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1497633883-21230-1-git-send-email-axboe@kernel.dk> References: <1497633883-21230-1-git-send-email-axboe@kernel.dk> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Reviewed-by: Andreas Dilger Signed-off-by: Jens Axboe --- fs/buffer.c | 14 +++++++++----- fs/mpage.c | 1 + 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index 161be58c5cb0..187e54fb0382 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -49,7 +49,7 @@ static int fsync_buffers_list(spinlock_t *lock, struct list_head *list); static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh, - struct writeback_control *wbc); + unsigned int stream, struct writeback_control *wbc); #define BH_ENTRY(list) list_entry((list), struct buffer_head, b_assoc_buffers) @@ -1829,7 +1829,8 @@ int __block_write_full_page(struct inode *inode, struct page *page, do { struct buffer_head *next = bh->b_this_page; if (buffer_async_write(bh)) { - submit_bh_wbc(REQ_OP_WRITE, write_flags, bh, wbc); + submit_bh_wbc(REQ_OP_WRITE, write_flags, bh, + inode_write_hint(inode), wbc); nr_underway++; } bh = next; @@ -1883,7 +1884,8 @@ int __block_write_full_page(struct inode *inode, struct page *page, struct buffer_head *next = bh->b_this_page; if (buffer_async_write(bh)) { clear_buffer_dirty(bh); - submit_bh_wbc(REQ_OP_WRITE, write_flags, bh, wbc); + submit_bh_wbc(REQ_OP_WRITE, write_flags, bh, + inode_write_hint(inode), wbc); nr_underway++; } bh = next; @@ -3091,7 +3093,7 @@ void guard_bio_eod(int op, struct bio *bio) } static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh, - struct writeback_control *wbc) + unsigned int write_hint, struct writeback_control *wbc) { struct bio *bio; @@ -3134,6 +3136,8 @@ static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh, op_flags |= REQ_META; if (buffer_prio(bh)) op_flags |= REQ_PRIO; + + op_flags |= write_hint_to_opf(write_hint); bio_set_op_attrs(bio, op, op_flags); submit_bio(bio); @@ -3142,7 +3146,7 @@ static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh, int submit_bh(int op, int op_flags, struct buffer_head *bh) { - return submit_bh_wbc(op, op_flags, bh, NULL); + return submit_bh_wbc(op, op_flags, bh, 0, NULL); } EXPORT_SYMBOL(submit_bh); diff --git a/fs/mpage.c b/fs/mpage.c index baff8f820c29..e84dcaee6ec7 100644 --- a/fs/mpage.c +++ b/fs/mpage.c @@ -614,6 +614,7 @@ static int __mpage_writepage(struct page *page, struct writeback_control *wbc, goto confused; wbc_init_bio(wbc, bio); + bio->bi_opf |= write_hint_to_opf(inode_write_hint(inode)); } /*