From patchwork Fri Apr 13 10:38:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Kent X-Patchwork-Id: 10339745 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1536A60329 for ; Fri, 13 Apr 2018 10:49:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 01F3D286C8 for ; Fri, 13 Apr 2018 10:49:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E9434286EF; Fri, 13 Apr 2018 10:49:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 79895286C8 for ; Fri, 13 Apr 2018 10:49:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754165AbeDMKtX (ORCPT ); Fri, 13 Apr 2018 06:49:23 -0400 Received: from icp-osb-irony-out1.external.iinet.net.au ([203.59.1.210]:8023 "EHLO icp-osb-irony-out1.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753800AbeDMKtV (ORCPT ); Fri, 13 Apr 2018 06:49:21 -0400 X-Greylist: delayed 601 seconds by postgrey-1.27 at vger.kernel.org; Fri, 13 Apr 2018 06:49:21 EDT X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2AvDwCFiNBa/1evLHlcg3OBWyiDZJUUS?= =?us-ascii?q?waBAjR8kmiBex6EcIIqITUXAQIBAQEBAQECbCiFTARSKAEMAhgOAkkWE4UADKc?= =?us-ascii?q?vgWkzGgKIKYIvgQmGdIEMgQeBPocYgzeCVAKMZIp6CI46h1iEbgGRPB0BNoFST?= =?us-ascii?q?S4Kgn2QWzIwjDOCRQEB?= X-IPAS-Result: =?us-ascii?q?A2AvDwCFiNBa/1evLHlcg3OBWyiDZJUUSwaBAjR8kmiBex6?= =?us-ascii?q?EcIIqITUXAQIBAQEBAQECbCiFTARSKAEMAhgOAkkWE4UADKcvgWkzGgKIKYIvg?= =?us-ascii?q?QmGdIEMgQeBPocYgzeCVAKMZIp6CI46h1iEbgGRPB0BNoFSTS4Kgn2QWzIwjDO?= =?us-ascii?q?CRQEB?= X-IronPort-AV: E=Sophos;i="5.48,445,1517846400"; d="scan'208";a="90028520" Received: from unknown (HELO pluto.themaw.net) ([121.44.175.87]) by icp-osb-irony-out1.iinet.net.au with ESMTP; 13 Apr 2018 18:38:56 +0800 Subject: [PATCH] autofs - mount point create should honour passed in mode From: Ian Kent To: Andrew Morton Cc: linux-fsdevel , autofs mailing list Date: Fri, 13 Apr 2018 18:38:56 +0800 Message-ID: <152361593601.8051.14014139124905996173.stgit@pluto.themaw.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The autofs file system mkdir inode operation blindly sets the created directory mode to S_IFDIR | 0555, ingoring the passed in mode, which can cause selinux dac_override denials. But the function also checks if the caller is the daemon (as no-one else should be able to do anything here) so there's no point in not honouring the passed in mode, allowing the daemon to set appropriate mode when required. Signed-off-by: Ian Kent Cc: stable@vger.kernel.org --- fs/autofs4/root.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c index 82e8f6edfb48..b12e37f27530 100644 --- a/fs/autofs4/root.c +++ b/fs/autofs4/root.c @@ -749,7 +749,7 @@ static int autofs4_dir_mkdir(struct inode *dir, autofs4_del_active(dentry); - inode = autofs4_get_inode(dir->i_sb, S_IFDIR | 0555); + inode = autofs4_get_inode(dir->i_sb, S_IFDIR | mode); if (!inode) return -ENOMEM; d_add(dentry, inode);