From patchwork Mon May 21 01:04:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Kent X-Patchwork-Id: 10413767 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 535F8601F9 for ; Mon, 21 May 2018 01:04:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4339128741 for ; Mon, 21 May 2018 01:04:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 36AED2873E; Mon, 21 May 2018 01:04:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E35152873E for ; Mon, 21 May 2018 01:04:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751556AbeEUBE0 (ORCPT ); Sun, 20 May 2018 21:04:26 -0400 Received: from icp-osb-irony-out1.external.iinet.net.au ([203.59.1.210]:49326 "EHLO icp-osb-irony-out1.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751109AbeEUBEZ (ORCPT ); Sun, 20 May 2018 21:04:25 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2BnCgApGgJb/+U/0XZaHgEGDINDgV4og?= =?us-ascii?q?3SUfEYBAQEBAQaBBzR8k0qBZB4YAYRAghMhNxUBAgEBAQEBAQJsKIVSVigBDAI?= =?us-ascii?q?YDgJJFhOFFgylU4IcGgKIIYIPgQmHLIEMgQeBDy+HHByDGIJUAoVAhmBjhAeHQ?= =?us-ascii?q?gmLJIMzgTeDbYJQfoQKASuRcTIigVJNLgqCfpBbMjB6AQGPKAEB?= X-IPAS-Result: =?us-ascii?q?A2BnCgApGgJb/+U/0XZaHgEGDINDgV4og3SUfEYBAQEBAQa?= =?us-ascii?q?BBzR8k0qBZB4YAYRAghMhNxUBAgEBAQEBAQJsKIVSVigBDAIYDgJJFhOFFgylU?= =?us-ascii?q?4IcGgKIIYIPgQmHLIEMgQeBDy+HHByDGIJUAoVAhmBjhAeHQgmLJIMzgTeDbYJ?= =?us-ascii?q?QfoQKASuRcTIigVJNLgqCfpBbMjB6AQGPKAEB?= X-IronPort-AV: E=Sophos;i="5.49,425,1520870400"; d="scan'208";a="99700747" Received: from unknown (HELO pluto.themaw.net) ([118.209.63.229]) by icp-osb-irony-out1.iinet.net.au with ESMTP; 21 May 2018 09:04:19 +0800 Subject: [PATCH] autofs - make autofs4 Kconfig depend on AUTOFS_FS From: Ian Kent To: Andrew Morton Cc: linux-fsdevel , autofs mailing list , Randy Dunlap , Kernel Mailing List Date: Mon, 21 May 2018 09:04:18 +0800 Message-ID: <152686465885.5980.4013776735694914550.stgit@pluto.themaw.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Setting AUTOFS_FS and AUTOFS4_FS to y or m results in a compile failure. It isn't possible to unset one if the other is set because it introduces a circular dependency. But adding "depends on AUTOFS_FS = n && AUTOFS_FS != m" will make autofs4 appear under the autofs entry which should call attention to it. It also results in AUTOFS4_FS being removed from .config for any setting of AUTOFS_FS except n. Adding a "NOTE" to the AUTOFS4_FS help text will hopefully raise awareness of the change to smooth the transition. Signed-off-by: Ian Kent Cc: Randy Dunlap Reported-by: Randy Dunlap Tested-by: Randy Dunlap --- fs/autofs4/Kconfig | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/fs/autofs4/Kconfig b/fs/autofs4/Kconfig index 53bc592a250d..2c2fdf989f90 100644 --- a/fs/autofs4/Kconfig +++ b/fs/autofs4/Kconfig @@ -1,6 +1,7 @@ config AUTOFS4_FS tristate "Kernel automounter version 4 support (also supports v3 and v5)" default n + depends on AUTOFS_FS = n help The automounter is a tool to automatically mount remote file systems on demand. This implementation is partially kernel-based to reduce @@ -30,3 +31,10 @@ config AUTOFS4_FS - any "alias autofs autofs4" will need to be removed. Please configure AUTOFS_FS instead of AUTOFS4_FS from now on. + + NOTE: Since the modules autofs and autofs4 use the same file system + type name of "autofs" only one can be built. The "depends" + above will result in AUTOFS4_FS not appearing in .config for + any setting of AUTOFS_FS other than n and AUTOFS4_FS will + appear under the AUTOFS_FS entry otherwise which is intended + to draw attention to the module rename change.