From patchwork Mon May 21 01:05:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Kent X-Patchwork-Id: 10413769 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AFA8B602A0 for ; Mon, 21 May 2018 01:05:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D5C8284D2 for ; Mon, 21 May 2018 01:05:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8D4B32874E; Mon, 21 May 2018 01:05:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1178C284D2 for ; Mon, 21 May 2018 01:05:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752552AbeEUBFq (ORCPT ); Sun, 20 May 2018 21:05:46 -0400 Received: from icp-osb-irony-out1.external.iinet.net.au ([203.59.1.210]:57702 "EHLO icp-osb-irony-out1.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751609AbeEUBFo (ORCPT ); Sun, 20 May 2018 21:05:44 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2BrCgApGgJb/+U/0XZaHgEGDINDgV4og?= =?us-ascii?q?3SUfEYBAQEBAQaBBzR8k0qBZB4YAYRAghMhOBQBAgEBAQEBAQJsKIVSVigBDAI?= =?us-ascii?q?YDgJJFhOFFgylU4IcGgKIIYIPgQmHLIEMgQeBPoc4gxiCVAKMIGOLSQmOV4E3g?= =?us-ascii?q?22CUIUIAZIcMyGBUk0uCoJ+giAXjiQyMHoBAY8oAQE?= X-IPAS-Result: =?us-ascii?q?A2BrCgApGgJb/+U/0XZaHgEGDINDgV4og3SUfEYBAQEBAQa?= =?us-ascii?q?BBzR8k0qBZB4YAYRAghMhOBQBAgEBAQEBAQJsKIVSVigBDAIYDgJJFhOFFgylU?= =?us-ascii?q?4IcGgKIIYIPgQmHLIEMgQeBPoc4gxiCVAKMIGOLSQmOV4E3g22CUIUIAZIcMyG?= =?us-ascii?q?BUk0uCoJ+giAXjiQyMHoBAY8oAQE?= X-IronPort-AV: E=Sophos;i="5.49,425,1520870400"; d="scan'208";a="99701058" Received: from unknown (HELO pluto.themaw.net) ([118.209.63.229]) by icp-osb-irony-out1.iinet.net.au with ESMTP; 21 May 2018 09:05:41 +0800 Subject: [PATCH] autofs - comment on selinux changes needed for module autoload From: Ian Kent To: Andrew Morton Cc: linux-fsdevel , autofs mailing list , Kernel Mailing List Date: Mon, 21 May 2018 09:05:41 +0800 Message-ID: <152686474171.6155.1239659539983577463.stgit@pluto.themaw.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Due to the autofs4 module using a file system type name of autofs different from the module containing directory name autoload did not function properly. To work around this kernel configurations have often elected to build the module into the kernel. This can result in selinux policies that prohibit autoloading of the autofs module which need to be changed. Add a comment about this to "possible changes" section of the autofs4 module help. Signed-off-by: Ian Kent --- fs/autofs4/Kconfig | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/autofs4/Kconfig b/fs/autofs4/Kconfig index 2c2fdf989f90..99fda4d6da25 100644 --- a/fs/autofs4/Kconfig +++ b/fs/autofs4/Kconfig @@ -29,6 +29,12 @@ config AUTOFS4_FS and the module name are the same as the file system name there is no need to manually load module. - any "alias autofs autofs4" will need to be removed. + - due to the autofs4 module directory name not being the same as + its file system name autoloading didn't work properly. Because + of this kernel configurations would often build the module into + the kernel. This may have resulted in selinux policies that will + prevent the autofs module from autoloading and will need to be + updated. Please configure AUTOFS_FS instead of AUTOFS4_FS from now on.