diff mbox series

[17/23] pid: Add pid namespaces into ns_idr

Message ID	159611045173.535980.13125182914304511849.stgit@localhost.localdomain (mailing list archive)
State	New, archived
Headers	show Return-Path: <SRS0=nZHl=BJ=vger.kernel.org=linux-fsdevel-owner@kernel.org> Subject: [PATCH 17/23] pid: Add pid namespaces into ns_idr From: Kirill Tkhai <ktkhai@virtuozzo.com> To: viro@zeniv.linux.org.uk, adobriyan@gmail.com, davem@davemloft.net, ebiederm@xmission.com, akpm@linux-foundation.org, christian.brauner@ubuntu.com, areber@redhat.com, serge@hallyn.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, ktkhai@virtuozzo.com Date: Thu, 30 Jul 2020 15:00:51 +0300 Message-ID: <159611045173.535980.13125182914304511849.stgit@localhost.localdomain> In-Reply-To: <159611007271.535980.15362304262237658692.stgit@localhost.localdomain> References: <159611007271.535980.15362304262237658692.stgit@localhost.localdomain> User-Agent: StGit/0.19 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk
Series	proc: Introduce /proc/namespaces/ directory to expose namespaces lineary \| expand [00/23] proc: Introduce /proc/namespaces/ directory to expose namespaces lineary [01/23] ns: Add common refcount into ns_common add use it as counter for net_ns [02/23] uts: Use generic ns_common::count [03/23] ipc: Use generic ns_common::count [04/23] pid: Use generic ns_common::count [05/23] user: Use generic ns_common::count [06/23] mnt: Use generic ns_common::count [07/23] cgroup: Use generic ns_common::count [08/23] time: Use generic ns_common::count [09/23] ns: Introduce ns_idr to be able to iterate all allocated namespaces in the system [10/23] fs: Rename fs/proc/namespaces.c into fs/proc/task_namespaces.c [11/23] fs: Add /proc/namespaces/ directory [12/23] user: Free user_ns one RCU grace period after final counter put [13/23] user: Add user namespaces into ns_idr [14/23] net: Add net namespaces into ns_idr [15/23] pid: Eextract child_reaper check from pidns_for_children_get() [16/23] proc_ns_operations: Add can_get method [17/23] pid: Add pid namespaces into ns_idr [18/23] uts: Free uts namespace one RCU grace period after final counter put [19/23] uts: Add uts namespaces into ns_idr [20/23] ipc: Add ipc namespaces into ns_idr [21/23] mnt: Add mount namespaces into ns_idr [22/23] cgroup: Add cgroup namespaces into ns_idr [23/23] time: Add time namespaces into ns_idr

Commit Message

Kirill Tkhai July 30, 2020, noon UTC

Now they are exposed in /proc/namespace/ directory.

Note, that we already wait RCU grace period before
pid namespace's memory is freed.

Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
---
 kernel/pid_namespace.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff mbox series

Patch

diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c
index da8490390f51..06398a7c4c59 100644
--- a/kernel/pid_namespace.c
+++ b/kernel/pid_namespace.c
@@ -109,8 +109,13 @@  static struct pid_namespace *create_pid_namespace(struct user_namespace *user_ns
 	ns->ucounts = ucounts;
 	ns->pid_allocated = PIDNS_ADDING;
 
+	if (ns_idr_register(&ns->ns) < 0)
+		goto out_free_inum;
+
 	return ns;
 
+out_free_inum:
+	ns_free_inum(&ns->ns);
 out_free_idr:
 	idr_destroy(&ns->idr);
 	kmem_cache_free(pid_ns_cachep, ns);
@@ -132,6 +137,7 @@  static void delayed_free_pidns(struct rcu_head *p)
 
 static void destroy_pid_namespace(struct pid_namespace *ns)
 {
+	ns_idr_unregister(&ns->ns);
 	ns_free_inum(&ns->ns);
 
 	idr_destroy(&ns->idr);
@@ -466,6 +472,7 @@  static __init int pid_namespaces_init(void)
 #ifdef CONFIG_CHECKPOINT_RESTORE
 	register_sysctl_paths(kern_path, pid_ns_ctl_table);
 #endif
+	WARN_ON(ns_idr_register(&init_pid_ns.ns) < 0);
 	return 0;
 }