| Message ID | 1615962899-77049-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | attr: replace if (cond) BUG() with BUG_ON() | expand |
diff --git a/fs/attr.c b/fs/attr.c index 87ef39d..43f369e 100644 --- a/fs/attr.c +++ b/fs/attr.c @@ -344,9 +344,7 @@ int notify_change(struct user_namespace *mnt_userns, struct dentry *dentry, * no function will ever call notify_change with both ATTR_MODE and * ATTR_KILL_S*ID set. */ - if ((ia_valid & (ATTR_KILL_SUID|ATTR_KILL_SGID)) && - (ia_valid & ATTR_MODE)) - BUG(); + BUG_ON((ia_valid & (ATTR_KILL_SUID|ATTR_KILL_SGID)) && (ia_valid & ATTR_MODE)); if (ia_valid & ATTR_KILL_SUID) { if (mode & S_ISUID) {
Fix the following coccicheck warnings: ./fs/attr.c:349:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- fs/attr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)