| Message ID | 20150123111304.GA5975@node.dhcp.inet.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 01/23/2015 03:13 AM, Kirill A. Shutemov wrote: > On Thu, Jan 22, 2015 at 09:04:45PM -0800, Guenter Roeck wrote: >> On Thu, Jan 22, 2015 at 03:05:17PM -0800, akpm@linux-foundation.org wrote: >>> The mm-of-the-moment snapshot 2015-01-22-15-04 has been uploaded to >>> >>> http://www.ozlabs.org/~akpm/mmotm/ >>> >> qemu:sh fails to shut down. >> >> bisect log: >> >> # bad: [03586ad04b2170ee816e6936981cc7cd2aeba129] pci: test for unexpectedly disabled bridges >> # good: [ec6f34e5b552fb0a52e6aae1a5afbbb1605cc6cc] Linux 3.19-rc5 >> git bisect start 'HEAD' 'v3.19-rc5' >> # bad: [d113ba21d15c7d3615fd88490d1197615bb39fc0] mm: remove lock validation check for MADV_FREE >> git bisect bad d113ba21d15c7d3615fd88490d1197615bb39fc0 >> # good: [17351d1625a5030fa16f1346b77064c03b51f107] mm:add KPF_ZERO_PAGE flag for /proc/kpageflags >> git bisect good 17351d1625a5030fa16f1346b77064c03b51f107 >> # good: [ad18ad1fce6f241a9cbd4adfd6b16c9283181e39] memcg: add BUILD_BUG_ON() for string tables >> git bisect good ad18ad1fce6f241a9cbd4adfd6b16c9283181e39 >> # bad: [aa7e7cbfa43b74f6faef04ff730b5098544a4f77] mm/compaction: enhance tracepoint output for compaction begin/end >> git bisect bad aa7e7cbfa43b74f6faef04ff730b5098544a4f77 >> # good: [a40d0d2cf21e2714e9a6c842085148c938bf36ab] mm: memcontrol: remove unnecessary soft limit tree node test >> git bisect good a40d0d2cf21e2714e9a6c842085148c938bf36ab >> # good: [4ec4aa2e07c1d6eee61f6cace29401c6febcb6c5] mm: make FIRST_USER_ADDRESS unsigned long on all archs >> git bisect good 4ec4aa2e07c1d6eee61f6cace29401c6febcb6c5 >> # bad: [22310c209483224a64436a6e815a86feda681659] mm: account pmd page tables to the process >> git bisect bad 22310c209483224a64436a6e815a86feda681659 >> # good: [19a41261b1dcd8d12372d9c57c2035144608a599] arm: define __PAGETABLE_PMD_FOLDED for !LPAE >> git bisect good 19a41261b1dcd8d12372d9c57c2035144608a599 >> # first bad commit: [22310c209483224a64436a6e815a86feda681659] mm: account pmd page tables to the process >> >> --- >> >> qemu:microblaze generates warnings to the console. >> >> WARNING: CPU: 0 PID: 32 at mm/mmap.c:2858 exit_mmap+0x184/0x1a4() >> >> with various call stacks. See >> http://server.roeck-us.net:8010/builders/qemu-microblaze-mmotm/builds/15/steps/qemubuildcommand/logs/stdio >> for details. > > Could you try patch below? Completely untested. > >>From b584bb8d493794f67484c0b57c161d61c02599bc Mon Sep 17 00:00:00 2001 > From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > Date: Fri, 23 Jan 2015 13:08:26 +0200 > Subject: [PATCH] microblaze: define __PAGETABLE_PMD_FOLDED > > Microblaze uses custom implementation of PMD folding, but doesn't define > __PAGETABLE_PMD_FOLDED, which generic code expects to see. Let's fix it. > > Defining __PAGETABLE_PMD_FOLDED will drop out unused __pmd_alloc(). > It also fixes problems with recently-introduced pmd accounting. > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > Reported-by: Guenter Roeck <linux@roeck-us.net> Tested working. Tested-by: Guenter Roeck <linux@roeck-us.net> Any idea how to fix the sh problem ? Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 23 Jan 2015 07:07:56 -0800 Guenter Roeck <linux@roeck-us.net> wrote: > >> > >> qemu:microblaze generates warnings to the console. > >> > >> WARNING: CPU: 0 PID: 32 at mm/mmap.c:2858 exit_mmap+0x184/0x1a4() > >> > >> with various call stacks. See > >> http://server.roeck-us.net:8010/builders/qemu-microblaze-mmotm/builds/15/steps/qemubuildcommand/logs/stdio > >> for details. > > > > Could you try patch below? Completely untested. > > > >>From b584bb8d493794f67484c0b57c161d61c02599bc Mon Sep 17 00:00:00 2001 > > From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > > Date: Fri, 23 Jan 2015 13:08:26 +0200 > > Subject: [PATCH] microblaze: define __PAGETABLE_PMD_FOLDED > > > > Microblaze uses custom implementation of PMD folding, but doesn't define > > __PAGETABLE_PMD_FOLDED, which generic code expects to see. Let's fix it. > > > > Defining __PAGETABLE_PMD_FOLDED will drop out unused __pmd_alloc(). > > It also fixes problems with recently-introduced pmd accounting. > > > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > > Reported-by: Guenter Roeck <linux@roeck-us.net> > > Tested working. > > Tested-by: Guenter Roeck <linux@roeck-us.net> > > Any idea how to fix the sh problem ? Can you tell us more about it? All I'm seeing is "qemu:sh fails to shut down", which isn't very clear. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/23/2015 01:55 PM, Andrew Morton wrote: > On Fri, 23 Jan 2015 07:07:56 -0800 Guenter Roeck <linux@roeck-us.net> wrote: > >>>> >>>> qemu:microblaze generates warnings to the console. >>>> >>>> WARNING: CPU: 0 PID: 32 at mm/mmap.c:2858 exit_mmap+0x184/0x1a4() >>>> >>>> with various call stacks. See >>>> http://server.roeck-us.net:8010/builders/qemu-microblaze-mmotm/builds/15/steps/qemubuildcommand/logs/stdio >>>> for details. >>> >>> Could you try patch below? Completely untested. >>> >>> >From b584bb8d493794f67484c0b57c161d61c02599bc Mon Sep 17 00:00:00 2001 >>> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> >>> Date: Fri, 23 Jan 2015 13:08:26 +0200 >>> Subject: [PATCH] microblaze: define __PAGETABLE_PMD_FOLDED >>> >>> Microblaze uses custom implementation of PMD folding, but doesn't define >>> __PAGETABLE_PMD_FOLDED, which generic code expects to see. Let's fix it. >>> >>> Defining __PAGETABLE_PMD_FOLDED will drop out unused __pmd_alloc(). >>> It also fixes problems with recently-introduced pmd accounting. >>> >>> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> >>> Reported-by: Guenter Roeck <linux@roeck-us.net> >> >> Tested working. >> >> Tested-by: Guenter Roeck <linux@roeck-us.net> >> >> Any idea how to fix the sh problem ? > > Can you tell us more about it? All I'm seeing is "qemu:sh fails to > shut down", which isn't very clear. > qemu command line: /opt/buildbot/bin/qemu-system-sh4 -M r2d -kernel ./arch/sh/boot/zImage \ -drive file=rootfs.ext2,if=ide \ -append "root=/dev/sda console=ttySC1,115200 noiotrap" -serial null -serial stdio -net nic,model=rtl8139 -net user -nographic -monitor null -- Poweroff log in mainline (v3.19-rc5-119-gb942c65): / # poweroff The system is going down NOW! Sent SIGTERM to all processes Sent SIGKILL to all processes Requesting system poweroff sd 0:0:0:0: [sda] Synchronizing SCSI cache sd 0:0:0:0: [sda] Stopping disk reboot: Power down -- Poweroff log in mmotm (v3.19-rc5-417-gc64429b): / # poweroff [ nothing else happens until I kill the qemu session ] The "halt" command does not work either. -- The message "The system is going down NOW" is from the init process. If I use "kill -12 1" instead of "halt" or "poweroff", the system does shut down as expected. "poweroff -f" also works. Trying to debug this further, I noticed that the "ps" command hangs as well, so the problem is not limited to poweroff or halt. I'll be happy to debug this further, I just have no idea where to start. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/23/2015 06:44 PM, Guenter Roeck wrote: > On 01/23/2015 01:55 PM, Andrew Morton wrote: >> On Fri, 23 Jan 2015 07:07:56 -0800 Guenter Roeck <linux@roeck-us.net> wrote: >> >>>>> >>>>> qemu:microblaze generates warnings to the console. >>>>> >>>>> WARNING: CPU: 0 PID: 32 at mm/mmap.c:2858 exit_mmap+0x184/0x1a4() >>>>> >>>>> with various call stacks. See >>>>> http://server.roeck-us.net:8010/builders/qemu-microblaze-mmotm/builds/15/steps/qemubuildcommand/logs/stdio >>>>> for details. >>>> >>>> Could you try patch below? Completely untested. >>>> >>>> >From b584bb8d493794f67484c0b57c161d61c02599bc Mon Sep 17 00:00:00 2001 >>>> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> >>>> Date: Fri, 23 Jan 2015 13:08:26 +0200 >>>> Subject: [PATCH] microblaze: define __PAGETABLE_PMD_FOLDED >>>> >>>> Microblaze uses custom implementation of PMD folding, but doesn't define >>>> __PAGETABLE_PMD_FOLDED, which generic code expects to see. Let's fix it. >>>> >>>> Defining __PAGETABLE_PMD_FOLDED will drop out unused __pmd_alloc(). >>>> It also fixes problems with recently-introduced pmd accounting. >>>> >>>> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> >>>> Reported-by: Guenter Roeck <linux@roeck-us.net> >>> >>> Tested working. >>> >>> Tested-by: Guenter Roeck <linux@roeck-us.net> >>> >>> Any idea how to fix the sh problem ? >> >> Can you tell us more about it? All I'm seeing is "qemu:sh fails to >> shut down", which isn't very clear. >> > > qemu command line: > > /opt/buildbot/bin/qemu-system-sh4 -M r2d -kernel ./arch/sh/boot/zImage \ > -drive file=rootfs.ext2,if=ide \ > -append "root=/dev/sda console=ttySC1,115200 noiotrap" > -serial null -serial stdio -net nic,model=rtl8139 -net user > -nographic -monitor null > > -- > Poweroff log in mainline (v3.19-rc5-119-gb942c65): > > / # poweroff > The system is going down NOW! > Sent SIGTERM to all processes > Sent SIGKILL to all processes > Requesting system poweroff > sd 0:0:0:0: [sda] Synchronizing SCSI cache > sd 0:0:0:0: [sda] Stopping disk > reboot: Power down > > -- > Poweroff log in mmotm (v3.19-rc5-417-gc64429b): > > / # poweroff > > [ nothing else happens until I kill the qemu session ] > > The "halt" command does not work either. > > -- > The message "The system is going down NOW" is from the init process. > If I use "kill -12 1" instead of "halt" or "poweroff", the system does > shut down as expected. "poweroff -f" also works. > > Trying to debug this further, I noticed that the "ps" command hangs > as well, so the problem is not limited to poweroff or halt. > > I'll be happy to debug this further, I just have no idea where to start. > Another data point: Reverting commit 22310c209483 does fix the problem. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/microblaze/include/asm/pgtable.h b/arch/microblaze/include/asm/pgtable.h index 46637bb090eb..e53b8532353c 100644 --- a/arch/microblaze/include/asm/pgtable.h +++ b/arch/microblaze/include/asm/pgtable.h @@ -61,6 +61,8 @@ extern int mem_init_done; #include <asm-generic/4level-fixup.h> +#define __PAGETABLE_PMD_FOLDED + #ifdef __KERNEL__ #ifndef __ASSEMBLY__