From patchwork Sun Mar 13 20:32:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 8573941 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id F2E829F758 for ; Sun, 13 Mar 2016 20:32:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0D53F20219 for ; Sun, 13 Mar 2016 20:32:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46F4A201F5 for ; Sun, 13 Mar 2016 20:32:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752892AbcCMUc3 (ORCPT ); Sun, 13 Mar 2016 16:32:29 -0400 Received: from sonata.ens-lyon.org ([140.77.166.138]:37525 "EHLO sonata.ens-lyon.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbcCMUc2 (ORCPT ); Sun, 13 Mar 2016 16:32:28 -0400 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id CF6B1200C4; Sun, 13 Mar 2016 21:32:25 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PCpvQFJ6Vo3s; Sun, 13 Mar 2016 21:32:25 +0100 (CET) Received: from var.youpi.perso.aquilenet.fr (LFbn-1-6757-94.w90-120.abo.wanadoo.fr [90.120.189.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 8D692200C1; Sun, 13 Mar 2016 21:32:25 +0100 (CET) Received: from samy by var.youpi.perso.aquilenet.fr with local (Exim 4.86_2) (envelope-from ) id 1afCga-0007C1-RQ; Sun, 13 Mar 2016 21:32:24 +0100 Date: Sun, 13 Mar 2016 21:32:24 +0100 From: Samuel Thibault To: Karel Zak Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, util-linux@vger.kernel.org Subject: Re: [ANNOUNCE] util-linux v2.28-rc1 Message-ID: <20160313203224.GR4295@var.home> Mail-Followup-To: Samuel Thibault , Karel Zak , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, util-linux@vger.kernel.org References: <20160311114701.oqbcsy2aiavj4ejz@ws.net.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160311114701.oqbcsy2aiavj4ejz@ws.net.home> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, 2.28-rc1 doesn't build on the Hurd system, see attached proposed patch. sigset_t is not a structure on Hurd. Applications are not supposed to assume what it is, and the first thing that sulogin.c does on it is sigemptyset already anyway. Samuel diff --git a/login-utils/sulogin.c b/login-utils/sulogin.c index 643712f..43ca0d4 100644 --- a/login-utils/sulogin.c +++ b/login-utils/sulogin.c @@ -859,7 +863,7 @@ int main(int argc, char **argv) struct passwd *pwd; struct timespec sigwait = { .tv_sec = 0, .tv_nsec = 50000000 }; siginfo_t status = {}; - sigset_t set = {}; + sigset_t set; int c, reconnect = 0; int opt_e = 0; int wait = 0;