From patchwork Fri Aug 12 02:47:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Kent X-Patchwork-Id: 9276261 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 199416022E for ; Fri, 12 Aug 2016 02:51:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0C22F2880A for ; Fri, 12 Aug 2016 02:51:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 012742880C; Fri, 12 Aug 2016 02:51:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9FC5E2880A for ; Fri, 12 Aug 2016 02:51:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752487AbcHLCsA (ORCPT ); Thu, 11 Aug 2016 22:48:00 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:32792 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752495AbcHLCr6 (ORCPT ); Thu, 11 Aug 2016 22:47:58 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 75FF52039B; Thu, 11 Aug 2016 22:47:57 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute7.internal (MEProxy); Thu, 11 Aug 2016 22:47:57 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=themaw.net; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=lKUwlJHMSWB72x/V7aKmA9Z2d68=; b=pMfOOI xbv6Fl3I7TT+RESNOKOZ+Gjoe7GINFjHrplYdUMF3fVN29BzJS5fFn3NIjhjGCcB tR2vZuM9VfVS9N8NDjzww2EvJV01jXALCoXnYKW4yNLAhWUCBnhF2tguFTWF6XQ2 KLj20kopKbKxRoPYVVD68RAooU7iD+XW+Cukk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=lKUwlJHMSWB72x/ V7aKmA9Z2d68=; b=MgjqMcCn4aJxh7UgbPSZwBYWMDIPIEMPxpL0lU5QPeo038G dkOXBbhsUoKQV5ZhWGbrv8Dx9AFkoW6ioPt7AGG3/xZaPa8FYjjOohcx+i5UpfM6 b44Kz4x1H8eg9QgymzdB/mlwGWY1FeMxVmOHg/0KG83BSVIYj04ckSzIfRLk= X-Sasl-enc: 5/d/EJM/Blzo+6l/8vJURN3eyZuxsQQE5m0Dy2J5Lvxm 1470970076 Received: from pluto.themaw.net (58-7-183-14.dyn.iinet.net.au [58.7.183.14]) by mail.messagingengine.com (Postfix) with ESMTPA id E52D4F285F; Thu, 11 Aug 2016 22:47:56 -0400 (EDT) Received: from pluto.themaw.net (localhost [127.0.0.1]) by pluto.themaw.net (Postfix) with ESMTP id DFAD7A0078; Fri, 12 Aug 2016 10:47:54 +0800 (AWST) Subject: [PATCH 05/18] autofs: Add WARN_ON(1) for non dir/link inode case From: Ian Kent To: Andrew Morton Cc: linux-fsdevel , Tomohiro Kusumi , autofs mailing list , Kernel Mailing List Date: Fri, 12 Aug 2016 10:47:54 +0800 Message-ID: <20160812024754.12352.8536.stgit@pluto.themaw.net> In-Reply-To: <20160812024734.12352.17122.stgit@pluto.themaw.net> References: <20160812024734.12352.17122.stgit@pluto.themaw.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Tomohiro Kusumi It's invalid if the given mode is neither dir nor link, so warn on else case. Signed-off-by: Tomohiro Kusumi Signed-off-by: Ian Kent --- fs/autofs4/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c index 64d721f..0dd4db9 100644 --- a/fs/autofs4/inode.c +++ b/fs/autofs4/inode.c @@ -368,7 +368,8 @@ struct inode *autofs4_get_inode(struct super_block *sb, umode_t mode) inode->i_fop = &autofs4_dir_operations; } else if (S_ISLNK(mode)) { inode->i_op = &autofs4_symlink_inode_operations; - } + } else + WARN_ON(1); return inode; }