From patchwork Fri Sep 16 12:07:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirill A . Shutemov" X-Patchwork-Id: 9335615 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2C93560839 for ; Fri, 16 Sep 2016 12:08:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1CF4C29F73 for ; Fri, 16 Sep 2016 12:08:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1141929F78; Fri, 16 Sep 2016 12:08:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8EA5729F6E for ; Fri, 16 Sep 2016 12:08:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934707AbcIPMHm (ORCPT ); Fri, 16 Sep 2016 08:07:42 -0400 Received: from mga02.intel.com ([134.134.136.20]:46658 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757722AbcIPMHk (ORCPT ); Fri, 16 Sep 2016 08:07:40 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 16 Sep 2016 05:07:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,344,1470726000"; d="scan'208";a="1031521994" Received: from unknown (HELO black.fi.intel.com) ([10.237.72.56]) by orsmga001.jf.intel.com with ESMTP; 16 Sep 2016 05:07:33 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id EFD9110D; Fri, 16 Sep 2016 15:07:32 +0300 (EEST) Date: Fri, 16 Sep 2016 15:07:32 +0300 From: "Kirill A. Shutemov" To: Theodore Ts'o , Andreas Dilger , Jan Kara , Andrew Morton Cc: Alexander Viro , Hugh Dickins , Andrea Arcangeli , Dave Hansen , Vlastimil Babka , Matthew Wilcox , Ross Zwisler , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org Subject: Re: [PATCHv3 07/41] mm, shmem: swich huge tmpfs to multi-order radix-tree entries Message-ID: <20160916120732.GA72667@black.fi.intel.com> References: <20160915115523.29737-1-kirill.shutemov@linux.intel.com> <20160915115523.29737-8-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160915115523.29737-8-kirill.shutemov@linux.intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Sep 15, 2016 at 02:54:49PM +0300, Kirill A. Shutemov wrote: > We would need to use multi-order radix-tree entires for ext4 and other > filesystems to have coherent view on tags (dirty/towrite) in the tree. > > This patch converts huge tmpfs implementation to multi-order entries, so > we will be able to use the same code patch for all filesystems. > > Signed-off-by: Kirill A. Shutemov 0-DAY reported this: reproduce: make htmldocs All warnings (new ones prefixed by >>): lib/crc32.c:148: warning: No description found for parameter 'tab)[256]' lib/crc32.c:148: warning: Excess function parameter 'tab' description in 'crc32_le_generic' lib/crc32.c:293: warning: No description found for parameter 'tab)[256]' lib/crc32.c:293: warning: Excess function parameter 'tab' description in 'crc32_be_generic' lib/crc32.c:1: warning: no structured comments found >> mm/filemap.c:1434: warning: No description found for parameter 'start' >> mm/filemap.c:1434: warning: Excess function parameter 'index' description in 'find_get_pages_contig' >> mm/filemap.c:1525: warning: No description found for parameter 'indexp' >> mm/filemap.c:1525: warning: Excess function parameter 'index' description in 'find_get_pages_tag' The fixup: diff --git a/mm/filemap.c b/mm/filemap.c index c69b1204744a..1ef20dd45b6b 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1548,7 +1548,7 @@ repeat: /** * find_get_pages_contig - gang contiguous pagecache lookup * @mapping: The address_space to search - * @index: The starting page index + * @start: The starting page index * @nr_pages: The maximum number of pages * @pages: Where the resulting pages are placed * @@ -1641,7 +1641,7 @@ EXPORT_SYMBOL(find_get_pages_contig); /** * find_get_pages_tag - find and return pages that match @tag * @mapping: the address_space to search - * @index: the starting page index + * @indexp: the starting page index * @tag: the tag index * @nr_pages: the maximum number of pages * @pages: where the resulting pages are placed