diff mbox

fscrypt: properly declare on-stack completion

Message ID 20170201203209.17710-1-richard@nod.at (mailing list archive)
State New, archived
Headers show

Commit Message

Richard Weinberger Feb. 1, 2017, 8:32 p.m. UTC 
When a completion is declared on-stack we have to use
COMPLETION_INITIALIZER_ONSTACK().

Fixes: 0b81d07790726 ("fs crypto: move per-file encryption from f2fs
tree to fs/crypto")
Signed-off-by: Richard Weinberger <richard@nod.at>

---
 fs/crypto/fscrypt_private.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Weinberger Feb. 1, 2017, 8:34 p.m. UTC | #1 
Am 01.02.2017 um 21:32 schrieb Richard Weinberger:
> When a completion is declared on-stack we have to use
> COMPLETION_INITIALIZER_ONSTACK().
> 
> Fixes: 0b81d07790726 ("fs crypto: move per-file encryption from f2fs
> tree to fs/crypto")
> Signed-off-by: Richard Weinberger <richard@nod.at>
> 
> ---
>  fs/crypto/fscrypt_private.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/crypto/fscrypt_private.h b/fs/crypto/fscrypt_private.h
> index aeab032d7d35..a0494a164f97 100644
> --- a/fs/crypto/fscrypt_private.h
> +++ b/fs/crypto/fscrypt_private.h
> @@ -81,7 +81,7 @@ struct fscrypt_completion_result {
>  
>  #define DECLARE_FS_COMPLETION_RESULT(ecr) \
>  	struct fscrypt_completion_result ecr = { \
> -		COMPLETION_INITIALIZER((ecr).completion), 0 }
> +		COMPLETION_INITIALIZER_ONSTACK((ecr).completion), 0 }
>  
>  
>  /* crypto.c */
> 

Replying with Ted's corrected mail address... ;-\

Thanks,
//richard
Theodore Ts'o Feb. 7, 2017, 4:21 a.m. UTC | #2 
On Wed, Feb 01, 2017 at 09:32:09PM +0100, Richard Weinberger wrote:
> When a completion is declared on-stack we have to use
> COMPLETION_INITIALIZER_ONSTACK().
> 
> Fixes: 0b81d07790726 ("fs crypto: move per-file encryption from f2fs
> tree to fs/crypto")
> Signed-off-by: Richard Weinberger <richard@nod.at>

Thanks, applied.

					- Ted
diff mbox

Patch

diff --git a/fs/crypto/fscrypt_private.h b/fs/crypto/fscrypt_private.h
index aeab032d7d35..a0494a164f97 100644
--- a/fs/crypto/fscrypt_private.h
+++ b/fs/crypto/fscrypt_private.h
@@ -81,7 +81,7 @@  struct fscrypt_completion_result {
 
 #define DECLARE_FS_COMPLETION_RESULT(ecr) \
 	struct fscrypt_completion_result ecr = { \
-		COMPLETION_INITIALIZER((ecr).completion), 0 }
+		COMPLETION_INITIALIZER_ONSTACK((ecr).completion), 0 }
 
 
 /* crypto.c */