| Message ID | 20170525105750.8663-1-jlayton@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, May 25, 2017 at 12:57 PM, Jeff Layton <jlayton@redhat.com> wrote: > This ensures that we see errors on fsync when writeback fails. > > Signed-off-by: Jeff Layton <jlayton@redhat.com> > Reviewed-by: Christoph Hellwig <hch@lst.de> > Reviewed-by: Jan Kara <jack@suse.cz> This is currently the only fuse patch for 4.12. Do you plan to send a pull to Linus with related things? If so then please feel free to take this and add my Acked-by: Miklos Szeredi <mszeredi@redhat.com> Thanks, Miklos > --- > fs/fuse/file.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/fuse/file.c b/fs/fuse/file.c > index 3ee4fdc3da9e..18518298d109 100644 > --- a/fs/fuse/file.c > +++ b/fs/fuse/file.c > @@ -1669,6 +1669,7 @@ static int fuse_writepage_locked(struct page *page) > err_free: > fuse_request_free(req); > err: > + mapping_set_error(page->mapping, error); > end_page_writeback(page); > return error; > } > -- > 2.9.4 >
On Mon, 2017-05-29 at 15:04 +0200, Miklos Szeredi wrote: > On Thu, May 25, 2017 at 12:57 PM, Jeff Layton <jlayton@redhat.com> wrote: > > This ensures that we see errors on fsync when writeback fails. > > > > Signed-off-by: Jeff Layton <jlayton@redhat.com> > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > Reviewed-by: Jan Kara <jack@suse.cz> > > This is currently the only fuse patch for 4.12. Do you plan to send a > pull to Linus with related things? If so then please feel free to > take this and add my > > Acked-by: Miklos Szeredi <mszeredi@redhat.com> > No, I wasn't planning to send a PR to Linus. I was really expecting these to go into v4.13 anyway (and maybe linux- next for now). I don't think it'll hurt to merge them into v4.12 though if you end up with other FUSE patches for v4.12 and want to merge it earlier. > > --- > > fs/fuse/file.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/fs/fuse/file.c b/fs/fuse/file.c > > index 3ee4fdc3da9e..18518298d109 100644 > > --- a/fs/fuse/file.c > > +++ b/fs/fuse/file.c > > @@ -1669,6 +1669,7 @@ static int fuse_writepage_locked(struct page *page) > > err_free: > > fuse_request_free(req); > > err: > > + mapping_set_error(page->mapping, error); > > end_page_writeback(page); > > return error; > > } > > -- > > 2.9.4 > > Thanks,
diff --git a/fs/fuse/file.c b/fs/fuse/file.c index 3ee4fdc3da9e..18518298d109 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -1669,6 +1669,7 @@ static int fuse_writepage_locked(struct page *page) err_free: fuse_request_free(req); err: + mapping_set_error(page->mapping, error); end_page_writeback(page); return error; }