diff mbox

f2fs: include seq_file.h for sysfs.c

Message ID 20170714010138.68665-1-jaegeuk@kernel.org (mailing list archive)
State New, archived
Headers show

Commit Message

Jaegeuk Kim July 14, 2017, 1:01 a.m. UTC 
This patch includes seq_file.h to avoid compile error.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 fs/f2fs/sysfs.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Chao Yu July 17, 2017, 2:25 p.m. UTC | #1 
Hi Jaegeuk,

On 2017/7/14 9:01, Jaegeuk Kim wrote:
> This patch includes seq_file.h to avoid compile error.

I didn't hit the error, I guess that's because we have included f2fs_fs.h
in sysfs.c, the inclusion relation is like this:
- sysfs.c
 - f2fs_fs.h
  - pagemap.h
   - fs.h
    - struct seq_file

Thanks,

> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>  fs/f2fs/sysfs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> index 9adc202fcd6f..71191d89917d 100644
> --- a/fs/f2fs/sysfs.c
> +++ b/fs/f2fs/sysfs.c
> @@ -11,6 +11,7 @@
>   */
>  #include <linux/proc_fs.h>
>  #include <linux/f2fs_fs.h>
> +#include <linux/seq_file.h>
>  
>  #include "f2fs.h"
>  #include "segment.h"
>
Jaegeuk Kim July 17, 2017, 4:55 p.m. UTC | #2 
On 07/17, Chao Yu wrote:
> Hi Jaegeuk,
> 
> On 2017/7/14 9:01, Jaegeuk Kim wrote:
> > This patch includes seq_file.h to avoid compile error.
> 
> I didn't hit the error, I guess that's because we have included f2fs_fs.h
> in sysfs.c, the inclusion relation is like this:
> - sysfs.c
>  - f2fs_fs.h
>   - pagemap.h
>    - fs.h
>     - struct seq_file

What about seq ops such as seq_puts?

Thanks,

> 
> Thanks,
> 
> > 
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> >  fs/f2fs/sysfs.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> > index 9adc202fcd6f..71191d89917d 100644
> > --- a/fs/f2fs/sysfs.c
> > +++ b/fs/f2fs/sysfs.c
> > @@ -11,6 +11,7 @@
> >   */
> >  #include <linux/proc_fs.h>
> >  #include <linux/f2fs_fs.h>
> > +#include <linux/seq_file.h>
> >  
> >  #include "f2fs.h"
> >  #include "segment.h"
> >
Chao Yu July 18, 2017, 1:23 a.m. UTC | #3 
On 2017/7/18 0:55, Jaegeuk Kim wrote:
> On 07/17, Chao Yu wrote:
>> Hi Jaegeuk,
>>
>> On 2017/7/14 9:01, Jaegeuk Kim wrote:
>>> This patch includes seq_file.h to avoid compile error.
>>
>> I didn't hit the error, I guess that's because we have included f2fs_fs.h
>> in sysfs.c, the inclusion relation is like this:
>> - sysfs.c
>>  - f2fs_fs.h
>>   - pagemap.h
>>    - fs.h
>>     - struct seq_file
> 
> What about seq ops such as seq_puts?

- sysfs.c
 - segment.h
  - linux/backing-dev.h
   - linux/writeback.h
#ifdef CONFIG_CGROUP_WRITEBACK
    - linux/cgroup.h
     - linux/seq_file.h
#endif

So it looks that there is no compiling error in my environment because
of CONFIG_CGROUP_WRITEBACK was defined.

Anyway, please add:

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

> 
> Thanks,
> 
>>
>> Thanks,
>>
>>>
>>> Signed-off-by: Eric Biggers <ebiggers@google.com>
>>> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
>>> ---
>>>  fs/f2fs/sysfs.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
>>> index 9adc202fcd6f..71191d89917d 100644
>>> --- a/fs/f2fs/sysfs.c
>>> +++ b/fs/f2fs/sysfs.c
>>> @@ -11,6 +11,7 @@
>>>   */
>>>  #include <linux/proc_fs.h>
>>>  #include <linux/f2fs_fs.h>
>>> +#include <linux/seq_file.h>
>>>  
>>>  #include "f2fs.h"
>>>  #include "segment.h"
>>>
> 
> .
>
diff mbox

Patch

diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
index 9adc202fcd6f..71191d89917d 100644
--- a/fs/f2fs/sysfs.c
+++ b/fs/f2fs/sysfs.c
@@ -11,6 +11,7 @@ 
  */
 #include <linux/proc_fs.h>
 #include <linux/f2fs_fs.h>
+#include <linux/seq_file.h>
 
 #include "f2fs.h"
 #include "segment.h"