From patchwork Wed Aug 30 15:23:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 9930057 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EA1B5603B4 for ; Wed, 30 Aug 2017 15:24:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DA8AD28488 for ; Wed, 30 Aug 2017 15:24:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CF049286D5; Wed, 30 Aug 2017 15:24:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4706728488 for ; Wed, 30 Aug 2017 15:24:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751834AbdH3PXd (ORCPT ); Wed, 30 Aug 2017 11:23:33 -0400 Received: from mail-qt0-f179.google.com ([209.85.216.179]:34161 "EHLO mail-qt0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751725AbdH3PXb (ORCPT ); Wed, 30 Aug 2017 11:23:31 -0400 Received: by mail-qt0-f179.google.com with SMTP id u11so28634188qtu.1 for ; Wed, 30 Aug 2017 08:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=erowGIdUYLOUKSdzoy4RfElkV0s8gG6UMeffn9ZU4Yo=; b=SglVCT3wG+WANF6H163RXhN7MkDvaT8kgAQTOQ7iDH83L2Gk4G3/h6P4boZQbFjk6v ASS6bPCrZRhAXMy+PvEUCoxLqGXz9DFUJXPGggtok2HaiLRJZsBEEvSVnHFvxvOWZYEl GyDbng7ofvM4aAS1ULbRuzv5GsoxEwmsKTltMygbjKtusyHMMuFK28EsUGrvi0OjYqHY zjXEF27zPrR/rEdxl97vssItiScPux9OpCKWbZhtchzGM73BE3PLf0p10paIx2AFbeXk 0qvC6GfmZ7K0UB1jUWqlscDdHLaO4h5PsfExfUbjxUsSKcb6Y8cSDD7emjayLUEU4Qya ZwvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=erowGIdUYLOUKSdzoy4RfElkV0s8gG6UMeffn9ZU4Yo=; b=nBB8GFc+J2+koZQFWyyoDQ4bSqyr8n7pGbQci4aIAzxTnG+F3ki80J7gI0uGRJYsBD J/OAztKnNPE9OvPGDC7SjI7Goxg8BsoFE8W7BQgnOSzGV4SKTCUacfR7eupiMPfUeeGT 9GDiBJHaiiArpG/NhDugFJlMeRkQAnGl9EKHZhPkHRRfwQOijyu/Rv7jaxWBwGw6K6Hk fk9r9spdRc8GlfLUFwFOUCtug7pQ1AS/Jd8y1lWpr7W2/CyTKNEaT7sGG/LofgKqD9JN vReAHPyFlEuUiU9vA2NN7bO8/PagjmPHZGFrHJ9bMWEMGljyTo0+30+96tN1a/E7oOdE g1cQ== X-Gm-Message-State: AHYfb5iejWQ5pYKivAlXUIHYZQIHONp5WmbdyCePHBesuJmI5tcHoK+I kWmd0TvlvK4xPWq5 X-Received: by 10.200.50.228 with SMTP id a33mr2771991qtb.81.1504106610828; Wed, 30 Aug 2017 08:23:30 -0700 (PDT) Received: from localhost ([2606:a000:4381:1201:225:22ff:feb3:e51a]) by smtp.gmail.com with ESMTPSA id q19sm4031406qta.17.2017.08.30.08.23.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Aug 2017 08:23:29 -0700 (PDT) Date: Wed, 30 Aug 2017 11:23:28 -0400 From: Josef Bacik To: Amir Goldstein Cc: Eryu Guan , Josef Bacik , "Darrick J . Wong" , Christoph Hellwig , fstests , linux-fsdevel , linux-xfs Subject: Re: [PATCH v2 00/14] Crash consistency xfstest using dm-log-writes Message-ID: <20170830152326.vil3fhsrecp2ccql@destiny> References: <1504104706-11965-1-git-send-email-amir73il@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170714 (1.8.3) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Aug 30, 2017 at 06:04:26PM +0300, Amir Goldstein wrote: > Sorry noise xfs list, I meant to CC fsdevel > > On Wed, Aug 30, 2017 at 5:51 PM, Amir Goldstein wrote: > > Hi all, > > > > This is the 2nd revision of crash consistency patch set. > > The main thing that changed since v1 is my confidence in the failures > > reported by the test, along with some more debugging options for > > running the test tools. > > > > I've collected these patches that have been sitting in Josef Bacik's > > tree for a few years and kicked them a bit into shape. > > The dm-log-writes target has been merged to kernel v4.1, see: > > https://github.com/torvalds/linux/blob/master/Documentation/device-mapper/log-writes.txt > > > > For this posting, I kept the random seeds constant for the test. > > I set these constant seeds after running with random seed for a little > > while and getting failure reports. With the current values in the test > > I was able to reproduce at high probablity failures with xfs, ext4 and btrfs. > > The probablity of reproducing the failure is higher on a spinning disk. > > I'd rather we make it as evil as possible. As long as we're printing out the seed that was used in the output then we can go in and manually change the test to use the same seed over and over again if we need to debug a problem. > > For xfs, I posted a fix for potential data loss post fsync+crash. > > For ext4, I posted a reliable reproducer using dm-flakey. > > For btrfs, I shared the recorded log with Josef. > > I posted a patch to fix the problem you reported by the way, but my git-send-email thing isn't set to cc people in the commit, sorry about that. > > There is an outstanding problem with the test - when I run it with > > kvm-xfstests, the test halts and I get soft lockup of log_writes_kthread. > > I suppose its a bug in dm-log-writes with some kernel config or with virtio > > I wasn't able to determine the reason and have little time to debug this. > > > > Since dm-log-writes is anyway in upstream kernel, I don't think a bug > > in dm-log-writes for a certain config is a reason to block this xfstest > > from being merged. > > Anyway, I would be glad if someone could take a look at the soft lockup > > issue. Josef? > > Yeah can you give this a try and see if the soft lockup goes away? diff --git a/drivers/md/dm-log-writes.c b/drivers/md/dm-log-writes.c index a1da0eb..b900758 100644 --- a/drivers/md/dm-log-writes.c +++ b/drivers/md/dm-log-writes.c @@ -345,6 +345,7 @@ static int log_writes_kthread(void *arg) struct pending_block *block = NULL; int ret; + cond_resched(); spin_lock_irq(&lc->blocks_lock); if (!list_empty(&lc->logging_blocks)) { block = list_first_entry(&lc->logging_blocks,