| Message ID | 20171030150131.2587-1-jlayton@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 2017-10-30 at 11:01 -0400, Jeff Layton wrote: > From: Jeff Layton <jlayton@redhat.com> > > There is no need to bump the i_version counter here, as ecryptfs does > not set the MS_I_VERSION flag, and doesn't use it internally. It also My apologies, I've been sitting on this patch for a while now. That should be changed to the SB_I_VERSION flag. Tyler, do you mind fixing that up before merge, or would you like me to resend? > only bumps it when the inode is instantiated, which doesn't make much > sense. > > Signed-off-by: Jeff Layton <jlayton@redhat.com> > --- > fs/ecryptfs/inode.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c > index efc2db42d175..b59b083379ea 100644 > --- a/fs/ecryptfs/inode.c > +++ b/fs/ecryptfs/inode.c > @@ -64,7 +64,6 @@ static int ecryptfs_inode_set(struct inode *inode, void *opaque) > /* i_size will be overwritten for encrypted regular files */ > fsstack_copy_inode_size(inode, lower_inode); > inode->i_ino = lower_inode->i_ino; > - inode->i_version++; > inode->i_mapping->a_ops = &ecryptfs_aops; > > if (S_ISLNK(inode->i_mode))
On 10/30/2017 10:03 AM, Jeff Layton wrote: > On Mon, 2017-10-30 at 11:01 -0400, Jeff Layton wrote: >> From: Jeff Layton <jlayton@redhat.com> >> >> There is no need to bump the i_version counter here, as ecryptfs does >> not set the MS_I_VERSION flag, and doesn't use it internally. It also > > My apologies, I've been sitting on this patch for a while now. That > should be changed to the SB_I_VERSION flag. Tyler, do you mind fixing > that up before merge, or would you like me to resend? That's no problem. Thanks for the patch! It looks good to me and I'll take it through my tree. Tyler > >> only bumps it when the inode is instantiated, which doesn't make much >> sense. >> >> Signed-off-by: Jeff Layton <jlayton@redhat.com> >> --- >> fs/ecryptfs/inode.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c >> index efc2db42d175..b59b083379ea 100644 >> --- a/fs/ecryptfs/inode.c >> +++ b/fs/ecryptfs/inode.c >> @@ -64,7 +64,6 @@ static int ecryptfs_inode_set(struct inode *inode, void *opaque) >> /* i_size will be overwritten for encrypted regular files */ >> fsstack_copy_inode_size(inode, lower_inode); >> inode->i_ino = lower_inode->i_ino; >> - inode->i_version++; >> inode->i_mapping->a_ops = &ecryptfs_aops; >> >> if (S_ISLNK(inode->i_mode)) >
diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c index efc2db42d175..b59b083379ea 100644 --- a/fs/ecryptfs/inode.c +++ b/fs/ecryptfs/inode.c @@ -64,7 +64,6 @@ static int ecryptfs_inode_set(struct inode *inode, void *opaque) /* i_size will be overwritten for encrypted regular files */ fsstack_copy_inode_size(inode, lower_inode); inode->i_ino = lower_inode->i_ino; - inode->i_version++; inode->i_mapping->a_ops = &ecryptfs_aops; if (S_ISLNK(inode->i_mode))