From patchwork Wed Nov 22 21:06:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wilcox X-Patchwork-Id: 10071313 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 82A456038F for ; Wed, 22 Nov 2017 21:34:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7539629B8D for ; Wed, 22 Nov 2017 21:34:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6964929D41; Wed, 22 Nov 2017 21:34:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 033C629B8D for ; Wed, 22 Nov 2017 21:34:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751561AbdKVVHv (ORCPT ); Wed, 22 Nov 2017 16:07:51 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:52224 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751470AbdKVVHr (ORCPT ); Wed, 22 Nov 2017 16:07:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=vQj7vDJAAEPuUr+mz+sfESMH4AYQVaJMGVmY2s4nZ8w=; b=f9NHHW6ozkFHThrM4u9wvvEID ry+tRiCAOwZlyTGjVMloZnzWcYHmmnroPxNzEl800QbknQeTp2wBDd6IdmlpGud8mUPYrW6EdW3Y8 +hmIxEGp2cgFsgNaTh6GRpIgu4RHoFqfhixK7UDLSAaI45OBiK9LTkhEU+jdqiMWPgldKzwgScWLV ffutj8UnK7LdnJOeJf+hJnWFZ9hCscQpuCLhulw3zrmIWT3nmGIlkc0uA1mA1Kw9FeW/uJaIQRzzU XlYt69KmwQssyDZPvIgTUC1BY0/O0N0UqYenUI34SZw/bPpHnpxQYOr64tfr+qhC7bo6aJclBDHaB +1dhTzIvw==; Received: from willy by bombadil.infradead.org with local (Exim 4.87 #1 (Red Hat Linux)) id 1eHcFG-0007oq-6Z; Wed, 22 Nov 2017 21:07:46 +0000 From: Matthew Wilcox To: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Matthew Wilcox Subject: [PATCH 03/62] radix tree test suite: Check reclaim bit Date: Wed, 22 Nov 2017 13:06:40 -0800 Message-Id: <20171122210739.29916-4-willy@infradead.org> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20171122210739.29916-1-willy@infradead.org> References: <20171122210739.29916-1-willy@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Matthew Wilcox In order to test the memory allocation failure paths, the radix tree test suite fails allocations if __GFP_NOWARN is set. That happens to work for the radix tree implementation, but the semantics we really want are that we want to fail allocations which are not GFP_KERNEL. Do this by failing allocations which don't have the DIRECT_RECLAIM bit set. Signed-off-by: Matthew Wilcox --- tools/testing/radix-tree/linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/radix-tree/linux.c b/tools/testing/radix-tree/linux.c index 6903ccf35595..f7f3caed3650 100644 --- a/tools/testing/radix-tree/linux.c +++ b/tools/testing/radix-tree/linux.c @@ -29,7 +29,7 @@ void *kmem_cache_alloc(struct kmem_cache *cachep, int flags) { struct radix_tree_node *node; - if (flags & __GFP_NOWARN) + if (!(flags & __GFP_DIRECT_RECLAIM)) return NULL; pthread_mutex_lock(&cachep->lock);