From patchwork Mon May 7 08:37:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miklos Szeredi X-Patchwork-Id: 10383659 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C9F2260159 for ; Mon, 7 May 2018 08:50:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C100228B78 for ; Mon, 7 May 2018 08:50:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BF75028B88; Mon, 7 May 2018 08:50:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 53B7328B78 for ; Mon, 7 May 2018 08:50:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752585AbeEGIta (ORCPT ); Mon, 7 May 2018 04:49:30 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:40254 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752015AbeEGIiQ (ORCPT ); Mon, 7 May 2018 04:38:16 -0400 Received: by mail-wm0-f68.google.com with SMTP id j5-v6so13823707wme.5 for ; Mon, 07 May 2018 01:38:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=t28YRwRGnAz5rkhSJhkqIpUFGu5tpsnKgArUU8nlD2g=; b=L+QlAlokqXAOeCbu/eFbfidUOqx2HykwzzbTrMOmRArUidb7fhdbMys5f/UuePmBdL j07axGpFr027nUZk8YN6hVyuXPskMEIKhk96DqFJS2bTZbPMKe2AUFD1jpMovPC8uJtt sl+qpU6CRcTyFw9sMURjq1rGjnBSn0fNJr5q0Ky36AmJ7DOuoUZt9qoSwpVugbB5Z7FW AM3h4YBCKeVOHvZjO+a+oBBxB5B06V0FvpgQ5nq5629Ik7nnOKmYncbAtH3sCTDeov59 3Yraqr4CnvEhk6aMbScT2ayE3YF3r6F8rWB7Ol3ZIWR+x5OQuEpG7fxRMCf682HpckAG 6xkA== X-Gm-Message-State: ALQs6tB/PuIpP3q9rMk2LeiIJTPSepw4RHRsVlbzvebaOCWKgaFC8H0c /7cXpDnazUl/5d0oCdc4beHGjw== X-Google-Smtp-Source: AB8JxZo20FYZxnjNQFIlkmuDCdmK2A+F4p1l7thJPOq8JeCqZZgWcM7rtCwkXqH+tWZHPppClCdpSQ== X-Received: by 2002:a1c:170f:: with SMTP id 15-v6mr179705wmx.90.1525682294855; Mon, 07 May 2018 01:38:14 -0700 (PDT) Received: from veci.piliscsaba.redhat.com (C2B0E321.catv.pool.telekom.hu. [194.176.227.33]) by smtp.gmail.com with ESMTPSA id h8-v6sm5908050wmc.16.2018.05.07.01.38.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 May 2018 01:38:14 -0700 (PDT) From: Miklos Szeredi To: linux-unionfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro Subject: [PATCH v2 02/35] vfs: optionally don't account file in nr_files Date: Mon, 7 May 2018 10:37:34 +0200 Message-Id: <20180507083807.28792-3-mszeredi@redhat.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180507083807.28792-1-mszeredi@redhat.com> References: <20180507083807.28792-1-mszeredi@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Stacking file operations in overlay will store an extra open file for each overlay file opened. The overhead is just that of "struct file" which is about 256bytes, because overlay already pins an extra dentry and inode when the file is open, which add up to a much larger overhead. For fear of breaking working setups, don't start accounting the extra file. The implementation adds a bool argument to path_open() to control whether the returned file is to be accounted or not. If the file is not accounted, f_mode will contain FMODE_NOACCOUNT, so that when freeing the file the count is not decremented. Signed-off-by: Miklos Szeredi --- fs/file_table.c | 13 +++++++++---- fs/internal.h | 7 ++++++- fs/open.c | 10 +++++----- include/linux/fs.h | 5 ++++- 4 files changed, 24 insertions(+), 11 deletions(-) diff --git a/fs/file_table.c b/fs/file_table.c index 7ec0b3e5f05d..60376bfa04cf 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -51,7 +51,8 @@ static void file_free_rcu(struct rcu_head *head) static inline void file_free(struct file *f) { - percpu_counter_dec(&nr_files); + if (!(f->f_mode & FMODE_NOACCOUNT)) + percpu_counter_dec(&nr_files); call_rcu(&f->f_u.fu_rcuhead, file_free_rcu); } @@ -100,7 +101,7 @@ int proc_nr_files(struct ctl_table *table, int write, * done, you will imbalance int the mount's writer count * and a warning at __fput() time. */ -struct file *get_empty_filp(void) +struct file *__get_empty_filp(bool account) { const struct cred *cred = current_cred(); static long old_max; @@ -110,7 +111,8 @@ struct file *get_empty_filp(void) /* * Privileged users can go above max_files */ - if (get_nr_files() >= files_stat.max_files && !capable(CAP_SYS_ADMIN)) { + if (account && + get_nr_files() >= files_stat.max_files && !capable(CAP_SYS_ADMIN)) { /* * percpu_counters are inaccurate. Do an expensive check before * we go and fail. @@ -123,7 +125,10 @@ struct file *get_empty_filp(void) if (unlikely(!f)) return ERR_PTR(-ENOMEM); - percpu_counter_inc(&nr_files); + if (account) + percpu_counter_inc(&nr_files); + else + f->f_mode = FMODE_NOACCOUNT; f->f_cred = get_cred(cred); error = security_file_alloc(f); if (unlikely(error)) { diff --git a/fs/internal.h b/fs/internal.h index e08972db0303..b82725ba3054 100644 --- a/fs/internal.h +++ b/fs/internal.h @@ -93,7 +93,12 @@ extern void chroot_fs_refs(const struct path *, const struct path *); /* * file_table.c */ -extern struct file *get_empty_filp(void); +extern struct file *__get_empty_filp(bool account); + +static inline struct file *get_empty_filp(void) +{ + return __get_empty_filp(true); +} /* * super.c diff --git a/fs/open.c b/fs/open.c index d0bf7f061a1a..6e52fd6fea7c 100644 --- a/fs/open.c +++ b/fs/open.c @@ -732,8 +732,8 @@ static int do_dentry_open(struct file *f, static const struct file_operations empty_fops = {}; int error; - f->f_mode = OPEN_FMODE(f->f_flags) | FMODE_LSEEK | - FMODE_PREAD | FMODE_PWRITE; + f->f_mode = (f->f_mode & FMODE_NOACCOUNT) | OPEN_FMODE(f->f_flags) | + FMODE_LSEEK | FMODE_PREAD | FMODE_PWRITE; path_get(&f->f_path); f->f_inode = inode; @@ -743,7 +743,7 @@ static int do_dentry_open(struct file *f, f->f_wb_err = filemap_sample_wb_err(f->f_mapping); if (unlikely(f->f_flags & O_PATH)) { - f->f_mode = FMODE_PATH; + f->f_mode = (f->f_mode & FMODE_NOACCOUNT) | FMODE_PATH; f->f_op = &empty_fops; goto done; } @@ -917,12 +917,12 @@ int vfs_open(const struct path *path, struct file *file, * Return: A pointer to a struct file or an IS_ERR pointer. Cannot return NULL. */ struct file *path_open(const struct path *path, int flags, struct inode *inode, - const struct cred *cred) + const struct cred *cred, bool account) { struct file *file; int retval; - file = get_empty_filp(); + file = __get_empty_filp(account); if (IS_ERR(file)) return file; diff --git a/include/linux/fs.h b/include/linux/fs.h index d97a661342c8..af49b55ff439 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -153,6 +153,9 @@ typedef int (dio_iodone_t)(struct kiocb *iocb, loff_t offset, /* File is capable of returning -EAGAIN if I/O will block */ #define FMODE_NOWAIT ((__force fmode_t)0x8000000) +/* File does not contribute to nr_files count */ +#define FMODE_NOACCOUNT ((__force fmode_t)0x10000000) + /* * Flag for rw_copy_check_uvector and compat_rw_copy_check_uvector * that indicates that they should check the contents of the iovec are @@ -2402,7 +2405,7 @@ extern struct file *file_open_root(struct dentry *, struct vfsmount *, const char *, int, umode_t); extern struct file * dentry_open(const struct path *, int, const struct cred *); extern struct file *path_open(const struct path *, int, struct inode *, - const struct cred *); + const struct cred *, bool); extern int filp_close(struct file *, fl_owner_t id); extern struct filename *getname_flags(const char __user *, int, int *);