From patchwork Tue May 29 21:17:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 10437073 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4F43F601E9 for ; Tue, 29 May 2018 21:17:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4185E28991 for ; Tue, 29 May 2018 21:17:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 363D72899C; Tue, 29 May 2018 21:17:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D67BD28991 for ; Tue, 29 May 2018 21:17:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967250AbeE2VRh (ORCPT ); Tue, 29 May 2018 17:17:37 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:39621 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967098AbeE2VRb (ORCPT ); Tue, 29 May 2018 17:17:31 -0400 Received: by mail-qk0-f196.google.com with SMTP id g14-v6so445807qkm.6 for ; Tue, 29 May 2018 14:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=w+V6Y0XmRixRJvb8sQo73wwHLu/MDd0HUHM44FdMrq0=; b=CvE7ZL4z27L8o3CU6WKQy2Rf+/qLOWHnaFIiHfX5e6zJRxt2rra7hFtswkA2p8OqoB c0P/eHpXn5IrvCpCp+VrxERzJ1+FsPvWkQT8ZC3JX2DvvaQwwVJGlEfyUUUzxfo09PIm IIwmum9GvkAxhFC3NEJzHSHsMDOAGZD8u/YNd7ybknjOnulK33u3RGXlQOL4tfzS6KC+ TuJ3suQFTMDdC+WRuxz/X85tZohBl9Y7LZZjxWWdXTB087bYQE8rR18OJdjobNIymrwt lB7zB6Zh0GSs511FjQ0T2p96HB1DXskUo2wlPnYk4X05K1NhPOtz3lan27Dk0tWh0qVq 0H1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=w+V6Y0XmRixRJvb8sQo73wwHLu/MDd0HUHM44FdMrq0=; b=p0YJik18uIM3EI3dTP4p31eec7rD6bfFGCT6FfGqreghDAbTQtXROSPxStVX9sWjGi LR0VuNhNewP7dzEwTOBPtp97KwXAJ4TTzJ7YD/HLDbC9n3duG7u9p+QqyeLYQahDtAj1 OKqXbVzcrCFcK+lid1XvweSwuf6HHCtLcY1ONJpB7oTjgLQxVpXDBRvWnUN+sgKiumqb pbDQKLG+UvCOZb3meInSC/+q5HtPrNRHBUnwVcDhzzzb5xB5jSKJKoiPl366/UGEnqGC 09cb0dW9RvnSJ7DDy1InH6Zccwa/fSKGGwZJAB17ovVpovc8Fwfgn45dKGNOTL1ZEu7t K2sA== X-Gm-Message-State: APt69E2Obd6Ex/MiepAz9iGfoVQPPPaIVgl65LxsyVF0vzR/Nigj9cGM pDTrHfNeOgdJFCTsgPTqFuY6og== X-Google-Smtp-Source: ADUXVKIqDa7RcPW58D/9JRPCYrHQmzujbpwCT9iybMqnf12I4YdUjdbwFneEZT+mia0LT6gGbmR4NQ== X-Received: by 2002:a37:21de:: with SMTP id f91-v6mr40778qki.395.1527628650788; Tue, 29 May 2018 14:17:30 -0700 (PDT) Received: from localhost (cpe-2606-A000-4381-1201-225-22FF-FEB3-E51A.dyn6.twc.com. [2606:a000:4381:1201:225:22ff:feb3:e51a]) by smtp.gmail.com with ESMTPSA id d2-v6sm8102982qto.71.2018.05.29.14.17.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 May 2018 14:17:29 -0700 (PDT) From: Josef Bacik To: axboe@kernel.dk, kernel-team@fb.com, linux-block@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, tj@kernel.org, linux-fsdevel@vger.kernel.org Cc: Josef Bacik Subject: [PATCH 02/13] block: introduce bio_issue_as_root_blkg Date: Tue, 29 May 2018 17:17:13 -0400 Message-Id: <20180529211724.4531-3-josef@toxicpanda.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180529211724.4531-1-josef@toxicpanda.com> References: <20180529211724.4531-1-josef@toxicpanda.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Josef Bacik Instead of forcing all file systems to get the right context on their bio's, simply check for REQ_META to see if we need to issue as the root blkg. We don't want to force all bio's to have the root blkg associated with them if REQ_META is set, as some controllers (blk-iolatency) need to know who the originating cgroup is so it can backcharge them for the work they are doing. This helper will make sure that the controllers do the proper thing wrt the IO priority and backcharging. Signed-off-by: Josef Bacik Acked-by: Tejun Heo --- include/linux/blk-cgroup.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/include/linux/blk-cgroup.h b/include/linux/blk-cgroup.h index 6c666fd7de3c..69aa71dc0c04 100644 --- a/include/linux/blk-cgroup.h +++ b/include/linux/blk-cgroup.h @@ -238,6 +238,22 @@ static inline struct blkcg *bio_blkcg(struct bio *bio) return css_to_blkcg(task_css(current, io_cgrp_id)); } +/** + * bio_issue_as_root_blkg - see if this bio needs to be issued as root blkg + * @return: true if this bio needs to be submitted with the root blkg context. + * + * In order to avoid priority inversions we sometimes need to issue a bio as if + * it were attached to the root blkg, and then backcharge to the actual owning + * blkg. The idea is we do bio_blkcg() to look up the actual context for the + * bio and attach the appropriate blkg to the bio. Then we call this helper and + * if it is true run with the root blkg for that queue and then do any + * backcharging to the originating cgroup once the io is complete. + */ +static inline bool bio_issue_as_root_blkg(struct bio *bio) +{ + return (bio->bi_opf & REQ_META); +} + /** * blkcg_parent - get the parent of a blkcg * @blkcg: blkcg of interest