From patchwork Wed Jun 20 13:10:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 10477567 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BFCA360230 for ; Wed, 20 Jun 2018 13:34:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ACDC92623D for ; Wed, 20 Jun 2018 13:34:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A1A3528ACF; Wed, 20 Jun 2018 13:34:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 04ADD2623D for ; Wed, 20 Jun 2018 13:34:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753202AbeFTNes (ORCPT ); Wed, 20 Jun 2018 09:34:48 -0400 Received: from gateway21.websitewelcome.com ([192.185.45.133]:32770 "EHLO gateway21.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752870AbeFTNes (ORCPT ); Wed, 20 Jun 2018 09:34:48 -0400 X-Greylist: delayed 1393 seconds by postgrey-1.27 at vger.kernel.org; Wed, 20 Jun 2018 09:34:47 EDT Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 5CAFD400D0800 for ; Wed, 20 Jun 2018 08:11:34 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id Vct5fleEBbXuJVctNfyPLY; Wed, 20 Jun 2018 08:11:33 -0500 X-Authority-Reason: nr=8 Received: from [189.250.65.56] (port=59518 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1fVct3-003EGb-Qv; Wed, 20 Jun 2018 08:11:01 -0500 Date: Wed, 20 Jun 2018 08:10:59 -0500 From: "Gustavo A. R. Silva" To: David Howells , Alexander Viro Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] fs/super.c: Fix lock/unlock imbalance in sget_fc Message-ID: <20180620131059.GA28925@embeddedor.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.65.56 X-Source-L: No X-Exim-ID: 1fVct3-003EGb-Qv X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.65.56]:59518 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 3 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It seems a spin_unlock is missing before return at line 532: return old. Addresses-Coverity-ID: 1470111 ("Missing unlock") Fixes: 4f3911e76e19 ("vfs: Implement a filesystem superblock creation/configuration context") Signed-off-by: Gustavo A. R. Silva --- fs/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/super.c b/fs/super.c index 43400f5..ff24532 100644 --- a/fs/super.c +++ b/fs/super.c @@ -529,6 +529,7 @@ struct super_block *sget_fc(struct fs_context *fc, destroy_unused_super(s); s = NULL; } + spin_unlock(&sb_lock); return old; } }