From patchwork Sun Jul 8 21:01:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Biggers X-Patchwork-Id: 10513351 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 13D94603D7 for ; Sun, 8 Jul 2018 21:07:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 061CE289DC for ; Sun, 8 Jul 2018 21:07:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EDBF3289E0; Sun, 8 Jul 2018 21:07:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A8FF7289DC for ; Sun, 8 Jul 2018 21:07:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933099AbeGHVHp (ORCPT ); Sun, 8 Jul 2018 17:07:45 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:44738 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933324AbeGHVFm (ORCPT ); Sun, 8 Jul 2018 17:05:42 -0400 Received: by mail-pf0-f193.google.com with SMTP id j3-v6so12135831pfh.11; Sun, 08 Jul 2018 14:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=a2wznl5oLZXcPz1y+G5D1hGknQD6LHneUq0w1LKB0Wc=; b=Fwi37R+ks+FtZeW8z+s+Mqf/fU+N1eCcQ5UpObIxVFToT/CMNej4d7W0p1jYwLllES nDF6JVmRUzyu4vYP5BQDK2RldyXSrm2nDEnBKw5zQKUSB+CaCVhuTc5JHPFnh3PKnHem ysPrX3E8V7HQCHjvApWKmWU4jStz8b799ugOPlv017IpXjCul3FOFvXW2WksB2uv7+Eu Te3JlShS/LXL+4ArH9VHTXLhjUzAbt9F9XLqaTQ7HoE/HsWjIG7tdk4lAGoM7dU4U2mj rUMWX4iIvXjq0rbimIOocPOtedbFhYPTdEHhwl9YSqDkrFOPBKb9BsHaCg9J7ucBzJWY ixVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=a2wznl5oLZXcPz1y+G5D1hGknQD6LHneUq0w1LKB0Wc=; b=MxJoxMWRt3JexBm9YJO7vjcM58Om8EAQO/mJIWMZLKQTxY9c5DsV3I+W+PFMie0LGd hHFAv5vUJKl2F7G9pJWkFzJ9m9hgOldR0UV/Vvc8TJ/smVYvYgHhiznhZWXg0uqAXS3G HGrwhiZmRuNVB2d0yL2PEeegTPMtdL22rvssC+L6vTo+M/6QNsZ0GTa7wB7s+vth+lPu 6Cn2lzGmzqh+/KL1tRy3URHSJAB0iZkvc6JWFFoaPv9mkwBJa1/GNyUr2DA0reHY2l8m 17qU/1GHLjR8RlwnaVBu5Alt+R70zgQzs6BRV7EAmZRd3wG3ZumqTBccVpFH56t0PssM VCvw== X-Gm-Message-State: APt69E1ichjjvSnDMuG/pyAs9mGHCUDwtPrTHSN6mhcTnsq2m1d9ZTJX 4HrhXjFwLc1ImPFwR5iHZwk= X-Google-Smtp-Source: AAOMgpcNwJCd7dlpYxvJoznrtKZ8YprIJ+WmPgG3vKz71YnkYNEhV5IDkcN1gJOcAFVuTA+6VR2azg== X-Received: by 2002:a62:fc5:: with SMTP id 66-v6mr14096610pfp.237.1531083942034; Sun, 08 Jul 2018 14:05:42 -0700 (PDT) Received: from sol.localdomain (c-67-185-97-198.hsd1.wa.comcast.net. [67.185.97.198]) by smtp.gmail.com with ESMTPSA id x68-v6sm23355681pfb.138.2018.07.08.14.05.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Jul 2018 14:05:41 -0700 (PDT) From: Eric Biggers To: David Howells , Alexander Viro , linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Eric Biggers Subject: [PATCH 11/18] fspick: fix path leak Date: Sun, 8 Jul 2018 14:01:47 -0700 Message-Id: <20180708210154.10423-12-ebiggers3@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180708210154.10423-1-ebiggers3@gmail.com> References: <20180708210154.10423-1-ebiggers3@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Eric Biggers Fixes: 99f8421020ac ("vfs: Implement fspick() to select a superblock for reconfiguration") Signed-off-by: Eric Biggers --- fs/fsopen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fsopen.c b/fs/fsopen.c index 8d6fa4ba8fb55..3e439299ddf79 100644 --- a/fs/fsopen.c +++ b/fs/fsopen.c @@ -301,7 +301,7 @@ SYSCALL_DEFINE3(fspick, int, dfd, const char __user *, path, unsigned int, flags ret = -EOPNOTSUPP; if (!target.dentry->d_sb->s_op->reconfigure) - goto err; + goto err_path; fc = vfs_new_fs_context(target.dentry->d_sb->s_type, target.dentry, 0, FS_CONTEXT_FOR_RECONFIGURE);