diff mbox

fsinfo: Fix off-by-one bug

Message ID 20180716220306.GA10773@embeddedor.com (mailing list archive)
State New, archived
Headers show

Commit Message

Gustavo A. R. Silva July 16, 2018, 10:03 p.m. UTC 
The current code reads one element beyond the end of the
fsinfo_buffer_sizes array.

Fixes: 4e635f61dd55 ("fsinfo: Add a system call to allow querying of filesystem information")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 fs/statfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gustavo A. R. Silva July 16, 2018, 10:09 p.m. UTC | #1 
Hi,

Please, drop this patch.

Sorry, I confused fsinfo_attr_statfs with fsinfo_attr__nr.

Thanks
--
Gustavo

On 07/16/2018 05:03 PM, Gustavo A. R. Silva wrote:
> The current code reads one element beyond the end of the
> fsinfo_buffer_sizes array.
> 
> Fixes: 4e635f61dd55 ("fsinfo: Add a system call to allow querying of filesystem information")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  fs/statfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/statfs.c b/fs/statfs.c
> index 3b8e2700..2a28581 100644
> --- a/fs/statfs.c
> +++ b/fs/statfs.c
> @@ -791,7 +791,7 @@ SYSCALL_DEFINE5(fsinfo,
>  		params.Mth = user_params.Mth;
>  	} else {
>  		params.at_flags = 0;
> -		params.request = fsinfo_attr_statfs;
> +		params.request = fsinfo_attr_statfs - 1;
>  		params.Nth = 0;
>  		params.Mth = 0;
>  	}
>
diff mbox

Patch

diff --git a/fs/statfs.c b/fs/statfs.c
index 3b8e2700..2a28581 100644
--- a/fs/statfs.c
+++ b/fs/statfs.c
@@ -791,7 +791,7 @@  SYSCALL_DEFINE5(fsinfo,
 		params.Mth = user_params.Mth;
 	} else {
 		params.at_flags = 0;
-		params.request = fsinfo_attr_statfs;
+		params.request = fsinfo_attr_statfs - 1;
 		params.Nth = 0;
 		params.Mth = 0;
 	}