| Message ID | 20181130192737.15053-13-jarkko.sakkinen@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On Fri, Nov 30, 2018 at 9:27 PM Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote: > > In order to comply with the CoC, replace **** with a hug. > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > --- > fs/notify/inotify/inotify_user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c > index 105576daca4a..db0b3b6d6a58 100644 > --- a/fs/notify/inotify/inotify_user.c > +++ b/fs/notify/inotify/inotify_user.c > @@ -446,7 +446,7 @@ static void inotify_remove_from_idr(struct fsnotify_group *group, > /* > * We found an mark in the idr at the right wd, but it's > * not the mark we were told to remove. eparis seriously > - * fucked up somewhere. > + * hugged up somewhere. > */ > if (unlikely(found_i_mark != i_mark)) { > WARN_ONCE(1, "%s: i_mark=%p i_mark->wd=%d i_mark->group=%p " LoL. doesn't shaming conflict with the CoC? Just remove this sentence - it adds no valuable information. While at it, please fix grammar "a mark". BTW, maybe you want to teach checkpatch.pl to alert about this sort of language... $ ./scripts/checkpatch.pl ./0001-test.patch WARNING: 'refered' may be misspelled - perhaps 'referred'? #4: Subject: [PATCH] fucked up refered to person Thanks, Amir.
On Sat 01-12-18 08:40:25, Amir Goldstein wrote: > On Fri, Nov 30, 2018 at 9:27 PM Jarkko Sakkinen > <jarkko.sakkinen@linux.intel.com> wrote: > > > > In order to comply with the CoC, replace **** with a hug. > > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > --- > > fs/notify/inotify/inotify_user.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c > > index 105576daca4a..db0b3b6d6a58 100644 > > --- a/fs/notify/inotify/inotify_user.c > > +++ b/fs/notify/inotify/inotify_user.c > > @@ -446,7 +446,7 @@ static void inotify_remove_from_idr(struct fsnotify_group *group, > > /* > > * We found an mark in the idr at the right wd, but it's > > * not the mark we were told to remove. eparis seriously > > - * fucked up somewhere. > > + * hugged up somewhere. > > */ > > if (unlikely(found_i_mark != i_mark)) { > > WARN_ONCE(1, "%s: i_mark=%p i_mark->wd=%d i_mark->group=%p " > > > LoL. doesn't shaming conflict with the CoC? > Just remove this sentence - it adds no valuable information. > While at it, please fix grammar "a mark". Agreed, just send a patch to remove that sentence and fixup the article. Btw, for the fun of it Eric has added this comment himself so I don't think this would really qualify as a CoC violation ;) Honza
diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c index 105576daca4a..db0b3b6d6a58 100644 --- a/fs/notify/inotify/inotify_user.c +++ b/fs/notify/inotify/inotify_user.c @@ -446,7 +446,7 @@ static void inotify_remove_from_idr(struct fsnotify_group *group, /* * We found an mark in the idr at the right wd, but it's * not the mark we were told to remove. eparis seriously - * fucked up somewhere. + * hugged up somewhere. */ if (unlikely(found_i_mark != i_mark)) { WARN_ONCE(1, "%s: i_mark=%p i_mark->wd=%d i_mark->group=%p "
In order to comply with the CoC, replace **** with a hug. Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> --- fs/notify/inotify/inotify_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)