| Message ID | 20191009032124.10541-6-david@fromorbit.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm, xfs: non-blocking inode reclaim | expand |
On Wed, Oct 09, 2019 at 02:21:03PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@redhat.com> > > The XFS inode item slab actually reclaimed by inode shrinker > callbacks from the memory reclaim subsystem. These should be marked > as reclaimable so the mm subsystem has the full picture of how much > memory it can actually reclaim from the XFS slab caches. > > Signed-off-by: Dave Chinner <dchinner@redhat.com> > --- Reviewed-by: Brian Foster <bfoster@redhat.com> > fs/xfs/xfs_super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index 8d1df9f8be07..f0aff1f034e6 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -1919,7 +1919,7 @@ xfs_init_zones(void) > > xfs_ili_zone = > kmem_zone_init_flags(sizeof(xfs_inode_log_item_t), "xfs_ili", > - KM_ZONE_SPREAD, NULL); > + KM_ZONE_SPREAD | KM_ZONE_RECLAIM, NULL); > if (!xfs_ili_zone) > goto out_destroy_inode_zone; > xfs_icreate_zone = kmem_zone_init(sizeof(struct xfs_icreate_item), > -- > 2.23.0.rc1 >
On Wed, Oct 09, 2019 at 02:21:03PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@redhat.com> > > The XFS inode item slab actually reclaimed by inode shrinker > callbacks from the memory reclaim subsystem. These should be marked > as reclaimable so the mm subsystem has the full picture of how much > memory it can actually reclaim from the XFS slab caches. > > Signed-off-by: Dave Chinner <dchinner@redhat.com> Seems fine to me... Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > --- > fs/xfs/xfs_super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index 8d1df9f8be07..f0aff1f034e6 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -1919,7 +1919,7 @@ xfs_init_zones(void) > > xfs_ili_zone = > kmem_zone_init_flags(sizeof(xfs_inode_log_item_t), "xfs_ili", > - KM_ZONE_SPREAD, NULL); > + KM_ZONE_SPREAD | KM_ZONE_RECLAIM, NULL); > if (!xfs_ili_zone) > goto out_destroy_inode_zone; > xfs_icreate_zone = kmem_zone_init(sizeof(struct xfs_icreate_item), > -- > 2.23.0.rc1 >
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 8d1df9f8be07..f0aff1f034e6 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -1919,7 +1919,7 @@ xfs_init_zones(void) xfs_ili_zone = kmem_zone_init_flags(sizeof(xfs_inode_log_item_t), "xfs_ili", - KM_ZONE_SPREAD, NULL); + KM_ZONE_SPREAD | KM_ZONE_RECLAIM, NULL); if (!xfs_ili_zone) goto out_destroy_inode_zone; xfs_icreate_zone = kmem_zone_init(sizeof(struct xfs_icreate_item),