[-next] io-wq: using kfree_rcu() to simplify the code

Commit Message

Yue Haibing Nov. 2, 2019, 7:55 a.m. UTC

The callback function of call_rcu() just calls a kfree(),
so can use kfree_rcu() instead of call_rcu() + callback function.

Signed-off-by: YueHaibing <[e-mail]>
---
 fs/io-wq.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

Comments

Jens Axboe Nov. 2, 2019, 1:59 p.m. UTC | #1

On 11/2/19 1:55 AM, YueHaibing wrote:
> The callback function of call_rcu() just calls a kfree(),
> so can use kfree_rcu() instead of call_rcu() + callback function.

Applied, thanks.

Patch

diff --git a/fs/io-wq.c b/fs/io-wq.c
index 652b8ba..3bbab2c 100644
--- a/fs/io-wq.c
+++ b/fs/io-wq.c
@@ -102,13 +102,6 @@  struct io_wq {
 	struct completion done;
 };
 
-static void io_wq_free_worker(struct rcu_head *head)
-{
-	struct io_worker *worker = container_of(head, struct io_worker, rcu);
-
-	kfree(worker);
-}
-
 static bool io_worker_get(struct io_worker *worker)
 {
 	return refcount_inc_not_zero(&worker->ref);
@@ -194,7 +187,7 @@  static void io_worker_exit(struct io_worker *worker)
 	if (all_done && refcount_dec_and_test(&wqe->wq->refs))
 		complete(&wqe->wq->done);
 
-	call_rcu(&worker->rcu, io_wq_free_worker);
+	kfree_rcu(worker, rcu);
 }
 
 static void io_worker_start(struct io_wqe *wqe, struct io_worker *worker)