diff mbox series

staging: exfat: make staging/exfat and fs/exfat mutually exclusive

Message ID 20200111121419.22669-1-linkinjeon@gmail.com (mailing list archive)
State New, archived
Headers show
Series staging: exfat: make staging/exfat and fs/exfat mutually exclusive | expand

Commit Message

Namjae Jeon Jan. 11, 2020, 12:14 p.m. UTC
From: Namjae Jeon <namjae.jeon@samsung.com>

Make staging/exfat and fs/exfat mutually exclusive to select the one
between two same filesystem.

Suggested-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
---
 drivers/staging/exfat/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg Kroah-Hartman Jan. 11, 2020, 5:56 p.m. UTC | #1
On Sat, Jan 11, 2020 at 09:14:19PM +0900, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
> 
> Make staging/exfat and fs/exfat mutually exclusive to select the one
> between two same filesystem.
> 
> Suggested-by: Amir Goldstein <amir73il@gmail.com>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> ---
>  drivers/staging/exfat/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/exfat/Kconfig b/drivers/staging/exfat/Kconfig
> index 292a19dfcaf5..9a0fccec65d9 100644
> --- a/drivers/staging/exfat/Kconfig
> +++ b/drivers/staging/exfat/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0
>  config STAGING_EXFAT_FS
>  	tristate "exFAT fs support"
> -	depends on BLOCK
> +	depends on BLOCK && !EXFAT_FS

There is no such symbol in the kernel tree, so this isn't going to do
anything :(

When/if EXFAT_FS does show up, I will be glad to add this.  Or better
yet, just have this as part of the "real" exfat patchset, that would
make the most sense, right?

thanks,

greg k-h
Namjae Jeon Jan. 11, 2020, 11:35 p.m. UTC | #2
2020-01-12 2:56 GMT+09:00, Greg KH <gregkh@linuxfoundation.org>:
> On Sat, Jan 11, 2020 at 09:14:19PM +0900, Namjae Jeon wrote:
>> From: Namjae Jeon <namjae.jeon@samsung.com>
>>
>> Make staging/exfat and fs/exfat mutually exclusive to select the one
>> between two same filesystem.
>>
>> Suggested-by: Amir Goldstein <amir73il@gmail.com>
>> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
>> ---
>>  drivers/staging/exfat/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/exfat/Kconfig
>> b/drivers/staging/exfat/Kconfig
>> index 292a19dfcaf5..9a0fccec65d9 100644
>> --- a/drivers/staging/exfat/Kconfig
>> +++ b/drivers/staging/exfat/Kconfig
>> @@ -1,7 +1,7 @@
>>  # SPDX-License-Identifier: GPL-2.0
>>  config STAGING_EXFAT_FS
>>  	tristate "exFAT fs support"
>> -	depends on BLOCK
>> +	depends on BLOCK && !EXFAT_FS
>
> There is no such symbol in the kernel tree, so this isn't going to do
> anything :(
>
> When/if EXFAT_FS does show up, I will be glad to add this.  Or better
> yet, just have this as part of the "real" exfat patchset, that would
> make the most sense, right?
Right,
Thanks!
>
> thanks,
>
> greg k-h
>
diff mbox series

Patch

diff --git a/drivers/staging/exfat/Kconfig b/drivers/staging/exfat/Kconfig
index 292a19dfcaf5..9a0fccec65d9 100644
--- a/drivers/staging/exfat/Kconfig
+++ b/drivers/staging/exfat/Kconfig
@@ -1,7 +1,7 @@ 
 # SPDX-License-Identifier: GPL-2.0
 config STAGING_EXFAT_FS
 	tristate "exFAT fs support"
-	depends on BLOCK
+	depends on BLOCK && !EXFAT_FS
 	select NLS
 	help
 	  This adds support for the exFAT file system.