| Message ID | 20200512181740.405774-1-fabf@skynet.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fs/notify: cleanup | expand |
On Tue 12-05-20 20:17:40, Fabian Frederick wrote: > kzalloc should already do it but explicitly initialize group > shutdown variable to false. > > Signed-off-by: Fabian Frederick <fabf@skynet.be> I don't think this patch makes sence. false is defined to be 0. kzalloc is there exactly so that we don't have to initialize fields that should be zero. Honza > --- > fs/notify/group.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/notify/group.c b/fs/notify/group.c > index 133f723aca07..f2cba2265061 100644 > --- a/fs/notify/group.c > +++ b/fs/notify/group.c > @@ -130,6 +130,7 @@ struct fsnotify_group *fsnotify_alloc_group(const struct fsnotify_ops *ops) > INIT_LIST_HEAD(&group->notification_list); > init_waitqueue_head(&group->notification_waitq); > group->max_events = UINT_MAX; > + group->shutdown = false; > > mutex_init(&group->mark_mutex); > INIT_LIST_HEAD(&group->marks_list); > -- > 2.26.2 >
diff --git a/fs/notify/group.c b/fs/notify/group.c index 133f723aca07..f2cba2265061 100644 --- a/fs/notify/group.c +++ b/fs/notify/group.c @@ -130,6 +130,7 @@ struct fsnotify_group *fsnotify_alloc_group(const struct fsnotify_ops *ops) INIT_LIST_HEAD(&group->notification_list); init_waitqueue_head(&group->notification_waitq); group->max_events = UINT_MAX; + group->shutdown = false; mutex_init(&group->mark_mutex); INIT_LIST_HEAD(&group->marks_list);
kzalloc should already do it but explicitly initialize group shutdown variable to false. Signed-off-by: Fabian Frederick <fabf@skynet.be> --- fs/notify/group.c | 1 + 1 file changed, 1 insertion(+)