diff mbox series

fs: binfmt_em86: check the result of remove_arg_zero()

Message ID 20201221121933.293635-1-masahiroy@kernel.org (mailing list archive)
State New, archived
Headers show
Series fs: binfmt_em86: check the result of remove_arg_zero() | expand

Commit Message

Masahiro Yamada Dec. 21, 2020, 12:19 p.m. UTC
Fix the following warning:

fs/binfmt_em86.c: In function 'load_em86':
fs/binfmt_em86.c:66:2: warning: ignoring return value of 'remove_arg_zero', declared with attribute warn_unused_result [-Wunused-result]
   66 |  remove_arg_zero(bprm);
      |  ^~~~~~~~~~~~~~~~~~~~~

Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 fs/binfmt_em86.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/fs/binfmt_em86.c b/fs/binfmt_em86.c
index 06b9b9fddf70..ba1e22b2e2a3 100644
--- a/fs/binfmt_em86.c
+++ b/fs/binfmt_em86.c
@@ -63,7 +63,9 @@  static int load_em86(struct linux_binprm *bprm)
 	 * This is done in reverse order, because of how the
 	 * user environment and arguments are stored.
 	 */
-	remove_arg_zero(bprm);
+	retval = remove_arg_zero(bprm);
+	if (retval)
+		return retval;
 	retval = copy_string_kernel(bprm->filename, bprm);
 	if (retval < 0) return retval; 
 	bprm->argc++;