diff mbox series

fs: block_dev.c: fix kernel-doc warnings from struct block_device changes

Message ID 20201229034706.30399-1-rdunlap@infradead.org (mailing list archive)
State New, archived
Headers show
Series fs: block_dev.c: fix kernel-doc warnings from struct block_device changes | expand

Commit Message

Randy Dunlap Dec. 29, 2020, 3:47 a.m. UTC 
Fix new kernel-doc warnings in fs/block_dev.c:

../fs/block_dev.c:1066: warning: Excess function parameter 'whole' description in 'bd_abort_claiming'
../fs/block_dev.c:1837: warning: Function parameter or member 'dev' not described in 'lookup_bdev'

Fixes: 4e7b5671c6a8 ("block: remove i_bdev")
Fixes: 37c3fc9abb25 ("block: simplify the block device claiming interface")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
---
 fs/block_dev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jens Axboe Dec. 29, 2020, 11:47 p.m. UTC | #1 
On 12/28/20 8:47 PM, Randy Dunlap wrote:
> Fix new kernel-doc warnings in fs/block_dev.c:
> 
> ../fs/block_dev.c:1066: warning: Excess function parameter 'whole' description in 'bd_abort_claiming'
> ../fs/block_dev.c:1837: warning: Function parameter or member 'dev' not described in 'lookup_bdev'

Applied, thanks.
Christoph Hellwig Jan. 4, 2021, 8:38 a.m. UTC | #2 
I sent two patches for that quite a while ago..
diff mbox series

Patch

--- lnx-511-rc1.orig/fs/block_dev.c
+++ lnx-511-rc1/fs/block_dev.c
@@ -1055,7 +1055,6 @@  static void bd_finish_claiming(struct bl
 /**
  * bd_abort_claiming - abort claiming of a block device
  * @bdev: block device of interest
- * @whole: whole block device
  * @holder: holder that has claimed @bdev
  *
  * Abort claiming of a block device when the exclusive open failed. This can be
@@ -1828,6 +1827,7 @@  const struct file_operations def_blk_fop
 /**
  * lookup_bdev  - lookup a struct block_device by name
  * @pathname:	special file representing the block device
+ * @dev:	return value of the block device's dev_t
  *
  * Get a reference to the blockdevice at @pathname in the current
  * namespace if possible and return it.  Return ERR_PTR(error)