diff mbox series

[-next] filesystems/locking: fix Malformed table warning

Message ID 20210727232212.12510-1-rdunlap@infradead.org (mailing list archive)
State New, archived
Headers show
Series [-next] filesystems/locking: fix Malformed table warning | expand

Commit Message

Randy Dunlap July 27, 2021, 11:22 p.m. UTC
Update the bottom border to be the same as the top border.

Documentation/filesystems/locking.rst:274: WARNING: Malformed table.
Bottom/header table border does not match top border.

Fixes: 730633f0b7f9 ("mm: Protect operations adding pages to page cache with invalidate_lock")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Darrick J. Wong <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org
---
 Documentation/filesystems/locking.rst |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Darrick J. Wong July 28, 2021, 12:04 a.m. UTC | #1
On Tue, Jul 27, 2021 at 04:22:12PM -0700, Randy Dunlap wrote:
> Update the bottom border to be the same as the top border.
> 
> Documentation/filesystems/locking.rst:274: WARNING: Malformed table.
> Bottom/header table border does not match top border.
> 
> Fixes: 730633f0b7f9 ("mm: Protect operations adding pages to page cache with invalidate_lock")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Darrick J. Wong <djwong@kernel.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Jan Kara <jack@suse.cz>
> Cc: linux-fsdevel@vger.kernel.org

Looks ugly but probably correct
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  Documentation/filesystems/locking.rst |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linext-20210727.orig/Documentation/filesystems/locking.rst
> +++ linext-20210727/Documentation/filesystems/locking.rst
> @@ -295,7 +295,7 @@ is_partially_uptodate:	yes
>  error_remove_page:	yes
>  swap_activate:		no
>  swap_deactivate:	no
> -======================	======================== =========
> +======================	======================== =========	===============
>  
>  ->write_begin(), ->write_end() and ->readpage() may be called from
>  the request handler (/dev/loop).
Jan Kara July 28, 2021, 1:20 p.m. UTC | #2
On Tue 27-07-21 17:04:09, Darrick J. Wong wrote:
> On Tue, Jul 27, 2021 at 04:22:12PM -0700, Randy Dunlap wrote:
> > Update the bottom border to be the same as the top border.
> > 
> > Documentation/filesystems/locking.rst:274: WARNING: Malformed table.
> > Bottom/header table border does not match top border.
> > 
> > Fixes: 730633f0b7f9 ("mm: Protect operations adding pages to page cache with invalidate_lock")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Darrick J. Wong <djwong@kernel.org>
> > Cc: Christoph Hellwig <hch@lst.de>
> > Cc: Jan Kara <jack@suse.cz>
> > Cc: linux-fsdevel@vger.kernel.org
> 
> Looks ugly but probably correct
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>

Thanks for the fix and for review! I've added the patch to my branch with
hole punch fixes.

								Honza
> > ---
> >  Documentation/filesystems/locking.rst |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- linext-20210727.orig/Documentation/filesystems/locking.rst
> > +++ linext-20210727/Documentation/filesystems/locking.rst
> > @@ -295,7 +295,7 @@ is_partially_uptodate:	yes
> >  error_remove_page:	yes
> >  swap_activate:		no
> >  swap_deactivate:	no
> > -======================	======================== =========
> > +======================	======================== =========	===============
> >  
> >  ->write_begin(), ->write_end() and ->readpage() may be called from
> >  the request handler (/dev/loop).
diff mbox series

Patch

--- linext-20210727.orig/Documentation/filesystems/locking.rst
+++ linext-20210727/Documentation/filesystems/locking.rst
@@ -295,7 +295,7 @@  is_partially_uptodate:	yes
 error_remove_page:	yes
 swap_activate:		no
 swap_deactivate:	no
-======================	======================== =========
+======================	======================== =========	===============
 
 ->write_begin(), ->write_end() and ->readpage() may be called from
 the request handler (/dev/loop).