diff mbox series

fs/file_table: fix adding missing kmemleak_not_leak()

Message ID 20220215020828.4180911-1-mcgrof@kernel.org (mailing list archive)
State New, archived
Headers show
Series fs/file_table: fix adding missing kmemleak_not_leak() | expand

Commit Message

Luis Chamberlain Feb. 15, 2022, 2:08 a.m. UTC 
Commit b42bc9a3c511 ("Fix regression due to
"fs: move binfmt_misc sysctl to its own file") fixed
a regression, however it failed to add a kmemleak_not_leak().

Fixes: b42bc9a3c511 ("Fix regression due to "fs: move binfmt_misc sysctl to its own file")
Reported-by: Tong Zhang <ztong0001@gmail.com>
Cc: Tong Zhang <ztong0001@gmail.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---

The fix for the regression was applied before we could
say Satoshi Nakamoto, and so it failed to carry the
little tidbit of using kmemleak_not_leak() to avoid the
false positive splat. Fix this.

 fs/file_table.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/fs/file_table.c b/fs/file_table.c
index 4969021fa676..7d2e692b66a9 100644
--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -27,6 +27,7 @@ 
 #include <linux/task_work.h>
 #include <linux/ima.h>
 #include <linux/swap.h>
+#include <linux/kmemleak.h>
 
 #include <linux/atomic.h>
 
@@ -119,8 +120,11 @@  static struct ctl_table fs_stat_sysctls[] = {
 static int __init init_fs_stat_sysctls(void)
 {
 	register_sysctl_init("fs", fs_stat_sysctls);
-	if (IS_ENABLED(CONFIG_BINFMT_MISC))
-		register_sysctl_mount_point("fs/binfmt_misc");
+	if (IS_ENABLED(CONFIG_BINFMT_MISC)) {
+		struct ctl_table_header *hdr;
+		hdr = register_sysctl_mount_point("fs/binfmt_misc");
+		kmemleak_not_leak(hdr);
+	}
 	return 0;
 }
 fs_initcall(init_fs_stat_sysctls);