diff mbox series

[09/12] f2fs: Correct f2fs_dirty_data_folio() conversion

Message ID 20220330144930.315951-10-willy@infradead.org (mailing list archive)
State New, archived
Headers show
Series Additional patches for 5.18 | expand

Commit Message

Matthew Wilcox March 30, 2022, 2:49 p.m. UTC 
I got the return value wrong.  Very little checks the return value
from set_page_dirty(), so nobody noticed during testing.

Fixes: 4f5e34f71318 ("f2fs: Convert f2fs_set_data_page_dirty to f2fs_dirty_data_folio")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 fs/f2fs/data.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig March 30, 2022, 2:53 p.m. UTC | #1 
On Wed, Mar 30, 2022 at 03:49:27PM +0100, Matthew Wilcox (Oracle) wrote:
> I got the return value wrong.  Very little checks the return value
> from set_page_dirty(), so nobody noticed during testing.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index c92920c8661d..8e0c2e773c8d 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -3571,7 +3571,7 @@  static bool f2fs_dirty_data_folio(struct address_space *mapping,
 		f2fs_update_dirty_folio(inode, folio);
 		return true;
 	}
-	return true;
+	return false;
 }