| Message ID | 20220330144930.315951-12-willy@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Additional patches for 5.18 | expand |
On Wed, Mar 30, 2022 at 03:49:29PM +0100, Matthew Wilcox (Oracle) wrote: > We've already done the work of block_dirty_folio() here, leaving > only the work that needs to be done by filemap_dirty_folio(). > This was a misconversion where I misread __set_page_dirty_nobuffers() > as __set_page_dirty_buffers(). Looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/fs/ntfs/aops.c b/fs/ntfs/aops.c index d154dcfe06af..90e3dad8ee45 100644 --- a/fs/ntfs/aops.c +++ b/fs/ntfs/aops.c @@ -1746,7 +1746,7 @@ void mark_ntfs_record_dirty(struct page *page, const unsigned int ofs) { set_buffer_dirty(bh); } while ((bh = bh->b_this_page) != head); spin_unlock(&mapping->private_lock); - block_dirty_folio(mapping, page_folio(page)); + filemap_dirty_folio(mapping, page_folio(page)); if (unlikely(buffers_to_free)) { do { bh = buffers_to_free->b_this_page;
We've already done the work of block_dirty_folio() here, leaving only the work that needs to be done by filemap_dirty_folio(). This was a misconversion where I misread __set_page_dirty_nobuffers() as __set_page_dirty_buffers(). Fixes: e621900ad28b ("fs: Convert __set_page_dirty_buffers to block_dirty_folio") Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- fs/ntfs/aops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)