| Message ID | 20220422212945.2227722-2-axelrasmussen@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | userfaultfd: add /dev/userfaultfd for fine grained access control | expand |
On 4/22/22 3:29 PM, Axel Rasmussen wrote: > This not being included was just a simple oversight. There are certain > features (like minor fault support) which are only enabled on shared > mappings, so without including hugetlb_shared we actually lose a > significant amount of test coverage. > > Signed-off-by: Axel Rasmussen <axelrasmussen@google.com> > --- > tools/testing/selftests/vm/run_vmtests.sh | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh > index a2302b5faaf2..5065dbd89bdb 100755 > --- a/tools/testing/selftests/vm/run_vmtests.sh > +++ b/tools/testing/selftests/vm/run_vmtests.sh > @@ -121,9 +121,11 @@ run_test ./gup_test -a > run_test ./gup_test -ct -F 0x1 0 19 0x1000 > > run_test ./userfaultfd anon 20 16 > -# Test requires source and destination huge pages. Size of source > -# (half_ufd_size_MB) is passed as argument to test. > +# Hugetlb tests require source and destination huge pages. Pass in half the > +# size ($half_ufd_size_MB), which is used for *each*. > run_test ./userfaultfd hugetlb "$half_ufd_size_MB" 32 > +run_test ./userfaultfd hugetlb_shared "$half_ufd_size_MB" 32 "$mnt"/uffd-test > +rm -f "$mnt"/uffd-test > run_test ./userfaultfd shmem 20 16 > > #cleanup > Looks good to me. Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> thanks, -- Shuah
On Fri, Apr 22, 2022 at 02:29:40PM -0700, Axel Rasmussen wrote: > This not being included was just a simple oversight. There are certain > features (like minor fault support) which are only enabled on shared > mappings, so without including hugetlb_shared we actually lose a > significant amount of test coverage. > > Signed-off-by: Axel Rasmussen <axelrasmussen@google.com> Reviewed-by: Peter Xu <peterx@redhat.com>
diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh index a2302b5faaf2..5065dbd89bdb 100755 --- a/tools/testing/selftests/vm/run_vmtests.sh +++ b/tools/testing/selftests/vm/run_vmtests.sh @@ -121,9 +121,11 @@ run_test ./gup_test -a run_test ./gup_test -ct -F 0x1 0 19 0x1000 run_test ./userfaultfd anon 20 16 -# Test requires source and destination huge pages. Size of source -# (half_ufd_size_MB) is passed as argument to test. +# Hugetlb tests require source and destination huge pages. Pass in half the +# size ($half_ufd_size_MB), which is used for *each*. run_test ./userfaultfd hugetlb "$half_ufd_size_MB" 32 +run_test ./userfaultfd hugetlb_shared "$half_ufd_size_MB" 32 "$mnt"/uffd-test +rm -f "$mnt"/uffd-test run_test ./userfaultfd shmem 20 16 #cleanup
This not being included was just a simple oversight. There are certain features (like minor fault support) which are only enabled on shared mappings, so without including hugetlb_shared we actually lose a significant amount of test coverage. Signed-off-by: Axel Rasmussen <axelrasmussen@google.com> --- tools/testing/selftests/vm/run_vmtests.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)