| Message ID | 20220714173819.13312-1-ubizjak@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | posix_acl: Use try_cmpxchg in get_acl | expand |
diff --git a/fs/posix_acl.c b/fs/posix_acl.c index 962d32468eb4..49a13fd4d3cb 100644 --- a/fs/posix_acl.c +++ b/fs/posix_acl.c @@ -164,7 +164,7 @@ struct posix_acl *get_acl(struct inode *inode, int type) * Cache the result, but only if our sentinel is still in place. */ posix_acl_dup(acl); - if (unlikely(cmpxchg(p, sentinel, acl) != sentinel)) + if (unlikely(!try_cmpxchg(p, &sentinel, acl))) posix_acl_release(acl); return acl; }
Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old in get_acl. x86 CMPXCHG instruction returns success in ZF flag, so this change saves a compare after cmpxchg (and related move instruction in front of cmpxchg). No functional change intended. Signed-off-by: Uros Bizjak <ubizjak@gmail.com> Cc: Alexander Viro <viro@zeniv.linux.org.uk> --- fs/posix_acl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)