From patchwork Thu Aug 18 21:01:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 12947940 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6A48C00140 for ; Thu, 18 Aug 2022 21:09:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346671AbiHRVJy (ORCPT ); Thu, 18 Aug 2022 17:09:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346637AbiHRVJW (ORCPT ); Thu, 18 Aug 2022 17:09:22 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F73DD83EF for ; Thu, 18 Aug 2022 14:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=gdwMVn08U0Xy1O 0ChHwkhYVnApy2tDKyoBT757de7NE=; b=gdxta6iGx7Uc4I/oV9LejgZ99B5mcd PFNWdgtE4wTl3W2RA4mrCtaZciN8jhCWb/sFyeb6iM7yiTK7RkBOzymkEdtofb0v WBz1G16tIq9ZBNDZ9SyMCkweP9WSUrLWaLN22gBe7eZYXbqRcWcEYSkzxnPIjQgz +Oi+8ms+iq4Es= Received: (qmail 3961932 invoked from network); 18 Aug 2022 23:01:26 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 18 Aug 2022 23:01:26 +0200 X-UD-Smtp-Session: l3s3148p1@MynhSIrmBb4ucref From: Wolfram Sang To: linux-kernel@vger.kernel.org Cc: Wolfram Sang , linux-fsdevel@vger.kernel.org Subject: [PATCH 03/14] proc: move from strlcpy with unused retval to strscpy Date: Thu, 18 Aug 2022 23:01:12 +0200 Message-Id: <20220818210123.7637-3-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220818210123.7637-1-wsa+renesas@sang-engineering.com> References: <20220818210123.7637-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ Signed-off-by: Wolfram Sang --- fs/proc/kcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c index dff921f7ca33..9f61d5d405f5 100644 --- a/fs/proc/kcore.c +++ b/fs/proc/kcore.c @@ -422,7 +422,7 @@ read_kcore(struct file *file, char __user *buffer, size_t buflen, loff_t *fpos) char *notes; size_t i = 0; - strlcpy(prpsinfo.pr_psargs, saved_command_line, + strscpy(prpsinfo.pr_psargs, saved_command_line, sizeof(prpsinfo.pr_psargs)); notes = kzalloc(notes_len, GFP_KERNEL);