diff mbox series

[1/9] mm: export mapping_seek_hole_data()

Message ID 20221115013043.360610-2-david@fromorbit.com (mailing list archive)
State New, archived
Headers show
Series xfs, iomap: fix data corrupton due to stale cached iomaps | expand

Commit Message

Dave Chinner Nov. 15, 2022, 1:30 a.m. UTC 
From: Dave Chinner <dchinner@redhat.com>

XFS needs this for finding cached dirty data regions when cleaning
up short writes, so it needs to be exported as XFS can be built as a
module.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 mm/filemap.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Christoph Hellwig Nov. 15, 2022, 8:40 a.m. UTC | #1 
On Tue, Nov 15, 2022 at 12:30:35PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> XFS needs this for finding cached dirty data regions when cleaning
> up short writes, so it needs to be exported as XFS can be built as a
> module.

NAK.  Even if you use these helpers to make your life a little easier,
the main delalloc punch logic belongs into iomap and not XFS, and does
not need the exports.
diff mbox series

Patch

diff --git a/mm/filemap.c b/mm/filemap.c
index 08341616ae7a..07d255c41c43 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -2925,6 +2925,7 @@  loff_t mapping_seek_hole_data(struct address_space *mapping, loff_t start,
 		return end;
 	return start;
 }
+EXPORT_SYMBOL_GPL(mapping_seek_hole_data);
 
 #ifdef CONFIG_MMU
 #define MMAP_LOTSAMISS  (100)