| Message ID | 20230110022554.1186499-3-mcgrof@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fs: kill old ms_* flags for internal sb | expand |
On Mon, Jan 09, 2023 at 06:25:53PM -0800, Luis Chamberlain wrote: > The goal behind 462ec50cb5 ("VFS: Differentiate mount flags (MS_*) from > internal superblock flags") was to phase out MS_* users for internal > uses. But we can't remove the old MS_* until we have all users out so > just use the SB_* helper for this check. No. The goal had been to separate the places where we deal with mount(2) argument encoding from those where we are deal with superblock flags. path_mount() is very much in the former class.
diff --git a/fs/namespace.c b/fs/namespace.c index ab467ee58341..bf1cc8527057 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -3411,7 +3411,7 @@ int path_mount(const char *dev_name, struct path *path, if (data_page) ((char *)data_page)[PAGE_SIZE - 1] = 0; - if (flags & MS_NOUSER) + if (flags & SB_NOUSER) return -EINVAL; ret = security_sb_mount(dev_name, path, type_page, flags, data_page);
The goal behind 462ec50cb5 ("VFS: Differentiate mount flags (MS_*) from internal superblock flags") was to phase out MS_* users for internal uses. But we can't remove the old MS_* until we have all users out so just use the SB_* helper for this check. Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- fs/namespace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)