| Message ID | 20230611123314.5282-1-dengshaomin@cdjrlc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | fs: Fix comment typo | expand |
On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote: > From: Mao Zhu <zhumao001@208suo.com> > > Delete duplicated word in comment. On what function? > > Signed-off-by: Mao Zhu <zhumao001@208suo.com> You're carrying someone else's patch, so besides SoB from original author, you need to also have your own SoB. > --- > include/linux/fs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index df6c1817906f..aa870b77cc2b 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -2675,7 +2675,7 @@ extern void evict_inodes(struct super_block *sb); > void dump_mapping(const struct address_space *); > > /* > - * Userspace may rely on the the inode number being non-zero. For example, glibc > + * Userspace may rely on the inode number being non-zero. For example, glibc > * simply ignores files with zero i_ino in unlink() and other places. > * > * As an additional complication, if userspace was compiled with I don't see the function name in above diff (dump_mapping() isn't the function I mean). Regardless, the fix LGTM. @cdjrlc.com developers: I'm really, really fed up with you ignoring review comments. It seems like you have issues on your mail setup. Fix your mailer! Until then, I just say NAK. Thanks.
Bagas Sanjaya <bagasdotme@gmail.com> writes: > On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote: >> From: Mao Zhu <zhumao001@208suo.com> >> >> Delete duplicated word in comment. > > On what function? Bagas, do I *really* have to ask you, yet again, to stop nitpicking our contributors into the ground? It appears I do. So: Bagas, *stop* this. It's a typo patch removing an extraneous word. The changelog is fine. We absolutely do not need you playing changelog cop and harassing contributors over this kind of thing. >> Signed-off-by: Mao Zhu <zhumao001@208suo.com> > > You're carrying someone else's patch, so besides SoB from original > author, you need to also have your own SoB. This, instead, is a valid problem that needs to be fixed. Thanks, jon
On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote: > Bagas Sanjaya <bagasdotme@gmail.com> writes: > > > On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote: > >> From: Mao Zhu <zhumao001@208suo.com> > >> > >> Delete duplicated word in comment. > > > > On what function? > > Bagas, do I *really* have to ask you, yet again, to stop nitpicking our > contributors into the ground? It appears I do. So: > > Bagas, *stop* this. It's a typo patch removing an extraneous word. The > changelog is fine. We absolutely do not need you playing changelog cop > and harassing contributors over this kind of thing. Amen. > >> Signed-off-by: Mao Zhu <zhumao001@208suo.com> > > > > You're carrying someone else's patch, so besides SoB from original > > author, you need to also have your own SoB. > > This, instead, is a valid problem that needs to be fixed. I mean ... yes, technically, it does. But it's a change that deletes a word in a comment. Honestly, I'd take the patch without any kind of sign-off. It doesn't create any copyright claim, which is the purpose of the DCO.
On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote: > Bagas Sanjaya <bagasdotme@gmail.com> writes: > > > On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote: > >> From: Mao Zhu <zhumao001@208suo.com> > >> > >> Delete duplicated word in comment. > > > > On what function? > > Bagas, do I *really* have to ask you, yet again, to stop nitpicking our > contributors into the ground? It appears I do. So: > > Bagas, *stop* this. It's a typo patch removing an extraneous word. The > changelog is fine. We absolutely do not need you playing changelog cop > and harassing contributors over this kind of thing. OK, thanks for reminding me again. At the time of reviewing, I had bad feeling that @cdjrlc.com people will ignore review comments (I betted due to mail setup problem that prevents them from properly repling to mailing lists, which is unfortunate). I was nitpicking because the diff context doesn't look clear to me (what function name?). > > >> Signed-off-by: Mao Zhu <zhumao001@208suo.com> > > > > You're carrying someone else's patch, so besides SoB from original > > author, you need to also have your own SoB. > > This, instead, is a valid problem that needs to be fixed. OK. Sorry for my inconvenience.
On 6/12/23 08:41, Bagas Sanjaya wrote: > On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote: >> Bagas Sanjaya <bagasdotme@gmail.com> writes: >> >>> On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote: >>>> From: Mao Zhu <zhumao001@208suo.com> >>>> >>>> Delete duplicated word in comment. >>> >>> On what function? >> >> Bagas, do I *really* have to ask you, yet again, to stop nitpicking our >> contributors into the ground? It appears I do. So: >> >> Bagas, *stop* this. It's a typo patch removing an extraneous word. The >> changelog is fine. We absolutely do not need you playing changelog cop >> and harassing contributors over this kind of thing. > > OK, thanks for reminding me again. > > At the time of reviewing, I had bad feeling that @cdjrlc.com people will > ignore review comments (I betted due to mail setup problem that prevents > them from properly repling to mailing lists, which is unfortunate). I > was nitpicking because the diff context doesn't look clear to me (what > function name?). > And no wonder why several maintainers also highlight this (which prompted me to review that way): [1]: https://lore.kernel.org/all/162b5545-7d24-3cf2-9158-3100ef644e03@linux.intel.com/ [2]: https://lore.kernel.org/all/3a73cf7f02915891c77dc5a3203dc187f6d91194.camel@HansenPartnership.com/
On Sun, Jun 11, 2023 at 09:07:22PM +0100, Matthew Wilcox wrote: > On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote: > > Bagas Sanjaya <bagasdotme@gmail.com> writes: > > > > > On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote: > > >> From: Mao Zhu <zhumao001@208suo.com> > > >> > > >> Delete duplicated word in comment. > > > > > > On what function? > > > > Bagas, do I *really* have to ask you, yet again, to stop nitpicking our > > contributors into the ground? It appears I do. So: > > > > Bagas, *stop* this. It's a typo patch removing an extraneous word. The > > changelog is fine. We absolutely do not need you playing changelog cop > > and harassing contributors over this kind of thing. > > Amen. > Amen too. Hope I can learn from this. > > >> Signed-off-by: Mao Zhu <zhumao001@208suo.com> > > > > > > You're carrying someone else's patch, so besides SoB from original > > > author, you need to also have your own SoB. > > > > This, instead, is a valid problem that needs to be fixed. > > I mean ... yes, technically, it does. But it's a change that deletes > a word in a comment. Honestly, I'd take the patch without any kind of > sign-off. It doesn't create any copyright claim, which is the purpose > of the DCO. What? Relaxed SoB requirement for trivial patches like this? I thought that SoB rules also apply to these patches. Thanks.
On Sun, 11 Jun 2023 08:33:14 -0400, Shaomin Deng wrote: > Delete duplicated word in comment. > > Missing sender SOB added. --- Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] fs: Fix comment typo https://git.kernel.org/vfs/vfs/c/dce5a4da3cf5
On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote: > Bagas Sanjaya <bagasdotme@gmail.com> writes: > > > On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote: > >> From: Mao Zhu <zhumao001@208suo.com> > >> > >> Delete duplicated word in comment. > > > > On what function? > > Bagas, do I *really* have to ask you, yet again, to stop nitpicking our > contributors into the ground? It appears I do. So: > > Bagas, *stop* this. It's a typo patch removing an extraneous word. The > changelog is fine. We absolutely do not need you playing changelog cop > and harassing contributors over this kind of thing. 100% agreed. > > >> Signed-off-by: Mao Zhu <zhumao001@208suo.com> > > > > You're carrying someone else's patch, so besides SoB from original > > author, you need to also have your own SoB. > > This, instead, is a valid problem that needs to be fixed. Patch picked up and missing sender SOB added.
On Mon, Jun 12, 2023 at 08:34:53AM +0200, Christian Brauner wrote: > On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote: > > Bagas Sanjaya <bagasdotme@gmail.com> writes: > > > > > On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote: > > >> From: Mao Zhu <zhumao001@208suo.com> > > >> > > >> Delete duplicated word in comment. > > > > > > On what function? > > > > Bagas, do I *really* have to ask you, yet again, to stop nitpicking our > > contributors into the ground? It appears I do. So: > > > > Bagas, *stop* this. It's a typo patch removing an extraneous word. The > > changelog is fine. We absolutely do not need you playing changelog cop > > and harassing contributors over this kind of thing. > > 100% agreed. > > > > > >> Signed-off-by: Mao Zhu <zhumao001@208suo.com> > > > > > > You're carrying someone else's patch, so besides SoB from original > > > author, you need to also have your own SoB. > > > > This, instead, is a valid problem that needs to be fixed. > > Patch picked up and missing sender SOB added. I've been informed that I may not be allowed to do that. So dropping the sender SOB for now following willy's argument.
On 6/12/23 15:34, Christian Brauner wrote: >> Patch picked up and missing sender SOB added. > > I've been informed that I may not be allowed to do that. > So dropping the sender SOB for now following willy's argument. OK, thanks for resolving!
diff --git a/include/linux/fs.h b/include/linux/fs.h index df6c1817906f..aa870b77cc2b 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2675,7 +2675,7 @@ extern void evict_inodes(struct super_block *sb); void dump_mapping(const struct address_space *); /* - * Userspace may rely on the the inode number being non-zero. For example, glibc + * Userspace may rely on the inode number being non-zero. For example, glibc * simply ignores files with zero i_ino in unlink() and other places. * * As an additional complication, if userspace was compiled with