| Message ID | 20230808161600.1099516-3-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/13] xfs: reformat the xfs_fs_free prototype | expand |
On Tue, Aug 08, 2023 at 09:15:49AM -0700, Christoph Hellwig wrote: > ->put_super is only called when sb->s_root is set, and thus when > fill_super succeeds. Thus drop the NULL check that can't happen in > xfs_fs_put_super. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- Looks good to me, Reviewed-by: Christian Brauner <brauner@kernel.org>
On Tue, Aug 08, 2023 at 09:15:49AM -0700, Christoph Hellwig wrote: > ->put_super is only called when sb->s_root is set, and thus when > fill_super succeeds. Thus drop the NULL check that can't happen in > xfs_fs_put_super. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Ahahaha, here's the /rest/ of the patchset. I wondered if vger was busted yesterday. Carrying on... Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > fs/xfs/xfs_super.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index 0a294659c18972..128f4a2924d49c 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -1132,10 +1132,6 @@ xfs_fs_put_super( > { > struct xfs_mount *mp = XFS_M(sb); > > - /* if ->fill_super failed, we have no mount to tear down */ > - if (!sb->s_fs_info) > - return; > - > xfs_notice(mp, "Unmounting Filesystem %pU", &mp->m_sb.sb_uuid); > xfs_filestream_unmount(mp); > xfs_unmountfs(mp); > -- > 2.39.2 >
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 0a294659c18972..128f4a2924d49c 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -1132,10 +1132,6 @@ xfs_fs_put_super( { struct xfs_mount *mp = XFS_M(sb); - /* if ->fill_super failed, we have no mount to tear down */ - if (!sb->s_fs_info) - return; - xfs_notice(mp, "Unmounting Filesystem %pU", &mp->m_sb.sb_uuid); xfs_filestream_unmount(mp); xfs_unmountfs(mp);
->put_super is only called when sb->s_root is set, and thus when fill_super succeeds. Thus drop the NULL check that can't happen in xfs_fs_put_super. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/xfs/xfs_super.c | 4 ---- 1 file changed, 4 deletions(-)