| Message ID | 20231002023613.GN3389589@ZenIV (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/15] rcu pathwalk: prevent bogus hard errors from may_lookup() | expand |
On Mon, Oct 2, 2023 at 5:36 AM Al Viro <viro@zeniv.linux.org.uk> wrote: > > ... into ->free_inode(), that is. > > Fixes: 0af950f57fef "ovl: move ovl_entry into ovl_inode" > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Reviewed-by: Amir Goldstein <amir73il@gmail.com> > --- > fs/overlayfs/super.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c > index def266b5e2a3..f09184b865ec 100644 > --- a/fs/overlayfs/super.c > +++ b/fs/overlayfs/super.c > @@ -167,6 +167,7 @@ static void ovl_free_inode(struct inode *inode) > struct ovl_inode *oi = OVL_I(inode); > > kfree(oi->redirect); > + kfree(oi->oe); > mutex_destroy(&oi->lock); > kmem_cache_free(ovl_inode_cachep, oi); > } > @@ -176,7 +177,7 @@ static void ovl_destroy_inode(struct inode *inode) > struct ovl_inode *oi = OVL_I(inode); > > dput(oi->__upperdentry); > - ovl_free_entry(oi->oe); > + ovl_stack_put(ovl_lowerstack(oi->oe), ovl_numlower(oi->oe)); > if (S_ISDIR(inode->i_mode)) > ovl_dir_cache_free(inode); > else > -- > 2.39.2 >
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c index def266b5e2a3..f09184b865ec 100644 --- a/fs/overlayfs/super.c +++ b/fs/overlayfs/super.c @@ -167,6 +167,7 @@ static void ovl_free_inode(struct inode *inode) struct ovl_inode *oi = OVL_I(inode); kfree(oi->redirect); + kfree(oi->oe); mutex_destroy(&oi->lock); kmem_cache_free(ovl_inode_cachep, oi); } @@ -176,7 +177,7 @@ static void ovl_destroy_inode(struct inode *inode) struct ovl_inode *oi = OVL_I(inode); dput(oi->__upperdentry); - ovl_free_entry(oi->oe); + ovl_stack_put(ovl_lowerstack(oi->oe), ovl_numlower(oi->oe)); if (S_ISDIR(inode->i_mode)) ovl_dir_cache_free(inode); else
... into ->free_inode(), that is. Fixes: 0af950f57fef "ovl: move ovl_entry into ovl_inode" Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- fs/overlayfs/super.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)