diff mbox series

[16/22] udf_fiiter_add_entry(): check for zero ->d_name.len is bogus...

Message ID 20231220052831.GO1674809@ZenIV (mailing list archive)
State New, archived
Headers show
Series PATCH 01/22] hostfs: use d_splice_alias() calling conventions to simplify failure exits | expand

Commit Message

Al Viro Dec. 20, 2023, 5:28 a.m. UTC
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 fs/udf/namei.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Jan Kara Dec. 21, 2023, 12:22 p.m. UTC | #1
On Wed 20-12-23 05:28:31, Al Viro wrote:
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Indeed.

Acked-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/udf/namei.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/udf/namei.c b/fs/udf/namei.c
> index a64102d63781..b1674e07d5a5 100644
> --- a/fs/udf/namei.c
> +++ b/fs/udf/namei.c
> @@ -228,8 +228,6 @@ static int udf_fiiter_add_entry(struct inode *dir, struct dentry *dentry,
>  	char name[UDF_NAME_LEN_CS0];
>  
>  	if (dentry) {
> -		if (!dentry->d_name.len)
> -			return -EINVAL;
>  		namelen = udf_put_filename(dir->i_sb, dentry->d_name.name,
>  					   dentry->d_name.len,
>  					   name, UDF_NAME_LEN_CS0);
> -- 
> 2.39.2
>
diff mbox series

Patch

diff --git a/fs/udf/namei.c b/fs/udf/namei.c
index a64102d63781..b1674e07d5a5 100644
--- a/fs/udf/namei.c
+++ b/fs/udf/namei.c
@@ -228,8 +228,6 @@  static int udf_fiiter_add_entry(struct inode *dir, struct dentry *dentry,
 	char name[UDF_NAME_LEN_CS0];
 
 	if (dentry) {
-		if (!dentry->d_name.len)
-			return -EINVAL;
 		namelen = udf_put_filename(dir->i_sb, dentry->d_name.name,
 					   dentry->d_name.len,
 					   name, UDF_NAME_LEN_CS0);