| Message ID | 20240208172024.23625-4-shikemeng@huaweicloud.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fixes and cleanups to fs-writeback | expand |
On Fri, 2024-02-09 at 01:20 +0800, Kemeng Shi wrote: > Remove unused parameter wb of finish_writeback_work. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com> > --- > fs/fs-writeback.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index edb0cff51673..2619f74ced70 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -166,8 +166,7 @@ static void wb_wakeup_delayed(struct bdi_writeback *wb) > spin_unlock_irq(&wb->work_lock); > } > > -static void finish_writeback_work(struct bdi_writeback *wb, > - struct wb_writeback_work *work) > +static void finish_writeback_work(struct wb_writeback_work *work) > { > struct wb_completion *done = work->done; > > @@ -196,7 +195,7 @@ static void wb_queue_work(struct bdi_writeback *wb, > list_add_tail(&work->list, &wb->work_list); > mod_delayed_work(bdi_wq, &wb->dwork, 0); > } else > - finish_writeback_work(wb, work); > + finish_writeback_work(work); > > spin_unlock_irq(&wb->work_lock); > } > @@ -2285,7 +2284,7 @@ static long wb_do_writeback(struct bdi_writeback *wb) > while ((work = get_next_work_item(wb)) != NULL) { > trace_writeback_exec(wb, work); > wrote += wb_writeback(wb, work); > - finish_writeback_work(wb, work); > + finish_writeback_work(work); > } > > /*
On Fri 09-02-24 01:20:20, Kemeng Shi wrote: > Remove unused parameter wb of finish_writeback_work. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Sure. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/fs-writeback.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index edb0cff51673..2619f74ced70 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -166,8 +166,7 @@ static void wb_wakeup_delayed(struct bdi_writeback *wb) > spin_unlock_irq(&wb->work_lock); > } > > -static void finish_writeback_work(struct bdi_writeback *wb, > - struct wb_writeback_work *work) > +static void finish_writeback_work(struct wb_writeback_work *work) > { > struct wb_completion *done = work->done; > > @@ -196,7 +195,7 @@ static void wb_queue_work(struct bdi_writeback *wb, > list_add_tail(&work->list, &wb->work_list); > mod_delayed_work(bdi_wq, &wb->dwork, 0); > } else > - finish_writeback_work(wb, work); > + finish_writeback_work(work); > > spin_unlock_irq(&wb->work_lock); > } > @@ -2285,7 +2284,7 @@ static long wb_do_writeback(struct bdi_writeback *wb) > while ((work = get_next_work_item(wb)) != NULL) { > trace_writeback_exec(wb, work); > wrote += wb_writeback(wb, work); > - finish_writeback_work(wb, work); > + finish_writeback_work(work); > } > > /* > -- > 2.30.0 >
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index edb0cff51673..2619f74ced70 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -166,8 +166,7 @@ static void wb_wakeup_delayed(struct bdi_writeback *wb) spin_unlock_irq(&wb->work_lock); } -static void finish_writeback_work(struct bdi_writeback *wb, - struct wb_writeback_work *work) +static void finish_writeback_work(struct wb_writeback_work *work) { struct wb_completion *done = work->done; @@ -196,7 +195,7 @@ static void wb_queue_work(struct bdi_writeback *wb, list_add_tail(&work->list, &wb->work_list); mod_delayed_work(bdi_wq, &wb->dwork, 0); } else - finish_writeback_work(wb, work); + finish_writeback_work(work); spin_unlock_irq(&wb->work_lock); } @@ -2285,7 +2284,7 @@ static long wb_do_writeback(struct bdi_writeback *wb) while ((work = get_next_work_item(wb)) != NULL) { trace_writeback_exec(wb, work); wrote += wb_writeback(wb, work); - finish_writeback_work(wb, work); + finish_writeback_work(work); } /*
Remove unused parameter wb of finish_writeback_work. Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> --- fs/fs-writeback.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)