diff mbox series

[03/14] writeback: fix done_index when hitting the wbc->nr_to_write

Message ID 20240215063649.2164017-4-hch@lst.de (mailing list archive)
State New, archived
Headers show
Series [01/14] writeback: don't call mapping_set_error on AOP_WRITEPAGE_ACTIVATE | expand

Commit Message

Christoph Hellwig Feb. 15, 2024, 6:36 a.m. UTC
When write_cache_pages finishes writing out a folio, it fails to update
done_index to account for the number of pages in the folio just written.
That means when range_cyclic writeback is restarted, it will be
restarted at this folio instead of after it as it should.  Fix that
by updating done_index before breaking out of the loop.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Acked-by: Dave Chinner <dchinner@redhat.com>
---
 mm/page-writeback.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 703e83c69ffe08..2679176da316b3 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -2505,6 +2505,7 @@  int write_cache_pages(struct address_space *mapping,
 			 * keep going until we have written all the pages
 			 * we tagged for writeback prior to entering this loop.
 			 */
+			done_index = folio->index + nr;
 			wbc->nr_to_write -= nr;
 			if (wbc->nr_to_write <= 0 &&
 			    wbc->sync_mode == WB_SYNC_NONE) {