diff mbox series

[3/6] workqueue: remove unnecessary import and function in wq_monitor.py

Message ID 20240320110222.6564-4-shikemeng@huaweicloud.com (mailing list archive)
State New, archived
Headers show
Series Improve visibility of writeback | expand

Commit Message

Kemeng Shi March 20, 2024, 11:02 a.m. UTC
Remove unnecessary import and function in wq_monitor.py

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
 tools/workqueue/wq_monitor.py | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

Comments

Tejun Heo March 20, 2024, 3:03 p.m. UTC | #1
On Wed, Mar 20, 2024 at 07:02:19PM +0800, Kemeng Shi wrote:
> Remove unnecessary import and function in wq_monitor.py
> 
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>

Ah, this is a workqueue patch. Do you mind sending this separately? I'll
apply it to the wq tree after -rc1.

Thanks.
Kemeng Shi March 21, 2024, 6:08 a.m. UTC | #2
on 3/20/2024 11:03 PM, Tejun Heo wrote:
> On Wed, Mar 20, 2024 at 07:02:19PM +0800, Kemeng Shi wrote:
>> Remove unnecessary import and function in wq_monitor.py
>>
>> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
> 
> Ah, this is a workqueue patch. Do you mind sending this separately? I'll
> apply it to the wq tree after -rc1.
Sure, I send it separately now. Thanks!
> 
> Thanks.
>
diff mbox series

Patch

diff --git a/tools/workqueue/wq_monitor.py b/tools/workqueue/wq_monitor.py
index a8856a9c45dc..9e964c5be40c 100644
--- a/tools/workqueue/wq_monitor.py
+++ b/tools/workqueue/wq_monitor.py
@@ -32,16 +32,13 @@  https://github.com/osandov/drgn.
   rescued  The number of work items executed by the rescuer.
 """
 
-import sys
 import signal
-import os
 import re
 import time
 import json
 
 import drgn
-from drgn.helpers.linux.list import list_for_each_entry,list_empty
-from drgn.helpers.linux.cpumask import for_each_possible_cpu
+from drgn.helpers.linux.list import list_for_each_entry
 
 import argparse
 parser = argparse.ArgumentParser(description=desc,
@@ -54,10 +51,6 @@  parser.add_argument('-j', '--json', action='store_true',
                     help='Output in json')
 args = parser.parse_args()
 
-def err(s):
-    print(s, file=sys.stderr, flush=True)
-    sys.exit(1)
-
 workqueues              = prog['workqueues']
 
 WQ_UNBOUND              = prog['WQ_UNBOUND']