From patchwork Wed Jul 31 07:39:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukas Bulwahn X-Patchwork-Id: 13748244 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C3791A7207 for ; Wed, 31 Jul 2024 07:39:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722411559; cv=none; b=TMjGNfxXfYP1KhwXwcm9blh7qFGWpqD4rOi6MuzVqaydV1Aqq9H7A3o9NpKZZHpbFv8kJK8sddvpQxSv5xCYH8OnY3T9pujYeQ8T8/oRPSmgCZa5xQjxaLW49N4pIFCe4IcsBJvtxM9XZQbMs/8PJ2wqpP79/bAAJ7BS28PJowQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722411559; c=relaxed/simple; bh=fFZMF3NiaRR6TpVbELAswq4kkn1Pf0ZbDbb3nw54F6Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=A22hFrONCItLW8+BiQYGDiz1FIaxsmohHgJoYlQM7hs+bAhnzGAV/sdqA7Qlt/vQ+UEOOjPccv8wAQ2UNPTS1itqdG984VdEhMbV/3hE4rwlUK3JA8XWLpeQ8Eow2bhQw/eMzBQojI4HT+TUZuXSL6aEzP9HLlvhq91BytHQDNc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cp/icNjX; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cp/icNjX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722411557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=t8p7PLZp26QdCSQ6mdeX8yU1Tl2ZcAQTz+tPUUyqyK8=; b=cp/icNjXTqtWRO2WQMshfuPlR8WhPBqZIuv7swJxiQirGS4jTgwYHmbt8MhrU8B9Fkr8tv rquusHDyF7VgjXKHXs7RAgJrjRiutbnJJg0z/BWy0XBFlyFyvgj54MA5kHl8xZRPzdYDMs OeaP5iugKpI9WC3rZpO2GuQwe1qH+6o= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-WSxBQICcNn-HlGlEqSoSfg-1; Wed, 31 Jul 2024 03:39:13 -0400 X-MC-Unique: WSxBQICcNn-HlGlEqSoSfg-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a7aa5885be3so490314066b.0 for ; Wed, 31 Jul 2024 00:39:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722411552; x=1723016352; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t8p7PLZp26QdCSQ6mdeX8yU1Tl2ZcAQTz+tPUUyqyK8=; b=E1yeM/jgZoQIHpZcALa9KgWnpDI5qF7o1izRFqmn0ViVY90UrNaS87SrSpOM9z/yWW jxhL3ssAE4EpmMbviRUpjeJx1m0SmFwtzd0FXIMa6WX9DMKOFiDtpw33XwPXhIW2vsil V3DYbJrIyvTPv7WR3BFPTN336LdC1hVY7ybYWgq2fcC33PMVol8iUrZbYt3cpJfRBhiX LMucJ9b3VdrCUrAFr5wsalb0V1Ioj7EfVS86Vht1qZgYRzeyvRn8v2tBi5xCL4exT9kA BbASyqzCxOsyxt9GYQe51+d1zMBvDv3yDyRMmUGqDf7L3ygBeV+t+Zq7SIPj16EouufJ OCEw== X-Forwarded-Encrypted: i=1; AJvYcCXjcSD6HKLJyAYNzFn2uVlUxx4NFOetjkbOBVnG0pAagLke7bb6fmtD4EiLdqjQ8bYLAYFfzKtxyBYcBZI5BpuDrqHy4ynTFHAhNTOy9g== X-Gm-Message-State: AOJu0YxjqQnsYRaqNMVa2ozX8KB6pYgIEwVtMdihz7mgUk2ElDn11FoF lNnwWaAz3NF+kBFuk4P+Pg2WLMbJ272HLnZdshAcXoNySkC0ZggQSjZ+llbce2NzzwWnaBXI/qI 0hucesQjMYo5PJV1AyG3LIq9cYTgu99vhk2Vakc2xY96CuD1W6Akx6V+UwKQaifo= X-Received: by 2002:a17:906:6a0f:b0:a77:dafb:2bf9 with SMTP id a640c23a62f3a-a7d4017958emr935767866b.49.1722411552487; Wed, 31 Jul 2024 00:39:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFtcaFjOt9xSfQUez2BWgFX52e9aHax58DcvCguPN8jHiEXgVGDi0rjSjC1wDm9eFWQJzoLUA== X-Received: by 2002:a17:906:6a0f:b0:a77:dafb:2bf9 with SMTP id a640c23a62f3a-a7d4017958emr935766166b.49.1722411551964; Wed, 31 Jul 2024 00:39:11 -0700 (PDT) Received: from lbulwahn-thinkpadx1carbongen9.rmtde.csb ([2a02:810d:7e40:14b0:4ce1:e394:7ac0:6905]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acab23704sm735377266b.3.2024.07.31.00.39.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 00:39:11 -0700 (PDT) From: Lukas Bulwahn X-Google-Original-From: Lukas Bulwahn To: David Howells , Jeff Layton , netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn Subject: [PATCH] netfs: clean up after renaming FSCACHE_DEBUG config Date: Wed, 31 Jul 2024 09:39:02 +0200 Message-ID: <20240731073902.69262-1-lukas.bulwahn@redhat.com> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Lukas Bulwahn Commit fcad93360df4 ("netfs: Rename CONFIG_FSCACHE_DEBUG to CONFIG_NETFS_DEBUG") renames the config, but introduces two issues: First, NETFS_DEBUG mistakenly depends on the non-existing config NETFS, whereas the actual intended config is called NETFS_SUPPORT. Second, the config renaming misses to adjust the documentation of the functionality of this config. Clean up those two points. Signed-off-by: Lukas Bulwahn --- Documentation/filesystems/caching/fscache.rst | 8 ++++---- fs/netfs/Kconfig | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/filesystems/caching/fscache.rst b/Documentation/filesystems/caching/fscache.rst index a74d7b052dc1..de1f32526cc1 100644 --- a/Documentation/filesystems/caching/fscache.rst +++ b/Documentation/filesystems/caching/fscache.rst @@ -318,10 +318,10 @@ where the columns are: Debugging ========= -If CONFIG_FSCACHE_DEBUG is enabled, the FS-Cache facility can have runtime -debugging enabled by adjusting the value in:: +If CONFIG_NETFS_DEBUG is enabled, the FS-Cache facility and NETFS support can +have runtime debugging enabled by adjusting the value in:: - /sys/module/fscache/parameters/debug + /sys/module/netfs/parameters/debug This is a bitmask of debugging streams to enable: @@ -343,6 +343,6 @@ This is a bitmask of debugging streams to enable: The appropriate set of values should be OR'd together and the result written to the control file. For example:: - echo $((1|8|512)) >/sys/module/fscache/parameters/debug + echo $((1|8|512)) >/sys/module/netfs/parameters/debug will turn on all function entry debugging. diff --git a/fs/netfs/Kconfig b/fs/netfs/Kconfig index 1b78e8b65ebc..7701c037c328 100644 --- a/fs/netfs/Kconfig +++ b/fs/netfs/Kconfig @@ -24,7 +24,7 @@ config NETFS_STATS config NETFS_DEBUG bool "Enable dynamic debugging netfslib and FS-Cache" - depends on NETFS + depends on NETFS_SUPPORT help This permits debugging to be dynamically enabled in the local caching management module. If this is set, the debugging output may be