diff mbox series

affs: Replace one-element array with flexible-array member

Message ID 20240827124839.81288-2-thorsten.blum@toblux.com (mailing list archive)
State New
Headers show
Series affs: Replace one-element array with flexible-array member | expand

Commit Message

Thorsten Blum Aug. 27, 2024, 12:48 p.m. UTC
Replace the deprecated one-element array with a modern flexible-array
member in the struct affs_root_head.

Add a comment that most struct members are not used, but kept as
documentation.

Link: https://github.com/KSPP/linux/issues/79
Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
 fs/affs/amigaffs.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

David Sterba Aug. 28, 2024, 11:27 a.m. UTC | #1
On Tue, Aug 27, 2024 at 02:48:40PM +0200, Thorsten Blum wrote:
> Replace the deprecated one-element array with a modern flexible-array
> member in the struct affs_root_head.
> 
> Add a comment that most struct members are not used, but kept as
> documentation.
> 
> Link: https://github.com/KSPP/linux/issues/79
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>

Added to affs queue, thanks.
diff mbox series

Patch

diff --git a/fs/affs/amigaffs.h b/fs/affs/amigaffs.h
index 1b973a669d23..da3217ab6adb 100644
--- a/fs/affs/amigaffs.h
+++ b/fs/affs/amigaffs.h
@@ -49,12 +49,13 @@  struct affs_short_date {
 
 struct affs_root_head {
 	__be32 ptype;
+	/* The following fields are not used, but kept as documentation. */
 	__be32 spare1;
 	__be32 spare2;
 	__be32 hash_size;
 	__be32 spare3;
 	__be32 checksum;
-	__be32 hashtable[1];
+	__be32 hashtable[];
 };
 
 struct affs_root_tail {